Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable labels for single-host gateway configmaps #17768

Closed
sparkoo opened this issue Sep 1, 2020 · 0 comments
Closed

configurable labels for single-host gateway configmaps #17768

sparkoo opened this issue Sep 1, 2020 · 0 comments
Assignees
@sparkoo
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.19

Comments

@sparkoo
Copy link
Member

sparkoo commented Sep 1, 2020 •
edited
Loading

Is your enhancement related to a problem? Please describe.

For single-host gateway configuration, we're labeling the ConfigMaps so configbump can watch them. These labels are currently hardcoded (https://github.com/eclipse/che/blob/master/infrastructures/kubernetes/src/main/java/org/eclipse/che/workspace/infrastructure/kubernetes/provision/GatewayRouterProvisioner.java#L40). We should make them configurable.

Describe the solution you'd like

introduce new config variable with labels that will be set into gateway configmaps.
default labels are app=che component=che-gateway-config

che.infra.kubernetes.singlehost.gateway.configmap_labels=app=che,component=che-gateway-config

Describe alternatives you've considered

Additional context

single-host epic: #12914
must be done in sync with che-operator work: eclipse-che/che-operator#378
@sparkoo sparkoo added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 1, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 1, 2020
@sparkoo sparkoo self-assigned this Sep 1, 2020
@sparkoo sparkoo added area/che-server severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 1, 2020
@sparkoo sparkoo mentioned this issue Sep 2, 2020
Merged
@sparkoo sparkoo closed this as completed in 6f7c156 Sep 3, 2020
@skabashnyuk skabashnyuk added this to the 7.19 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sparkoo sparkoo

Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.19
Development

No branches or pull requests
3 participants
@sparkoo @skabashnyuk @che-bot