make single-host gateway configmap labels configurable #17775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
requested review from
amisevsk,
ibuziuk,
l0rd,
nickboldt and
sleshchenko
as code owners
che-bot
added
status/code-review
Signed-off-by: Michal Vala <mvala@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
metlos
reviewed
Sep 2, 2020
...in/java/org/eclipse/che/workspace/infrastructure/kubernetes/util/GatewayConfigmapLabels.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
skabashnyuk
reviewed
Sep 3, 2020
assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Michal Vala <mvala@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
skabashnyuk
approved these changes
Sep 3, 2020
...in/java/org/eclipse/che/workspace/infrastructure/kubernetes/util/GatewayConfigmapLabels.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/che/workspace/infrastructure/kubernetes/util/GatewayConfigmapLabels.java
Outdated
Show resolved
Hide resolved
…not set correctly + minor refactor Signed-off-by: Michal Vala <mvala@redhat.com>
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Vala mvala@redhat.com
What does this PR do?
Configurable labels for single-host gateway configmaps with
che.infra.kubernetes.singlehost.gateway.configmap_labelsconfig property.changed
che.infra.kubernetes.single_host.workspace.exposuretoche.infra.kubernetes.singlehost.workspace.exposureWhat issues does this PR fix or reference?
#17768
Release Notes
Docs PR