-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move sidecars definitions into plugin-registry #18217
Closed
Labels
area/plugin-registry
kind/task
Internal things, technical debt, and to-do tasks to be performed.
severity/P2
Has a minor but important impact to the usage or development of the system.
Milestone
Comments
benoitf
added
kind/task
Internal things, technical debt, and to-do tasks to be performed.
area/plugin-registry
labels
Oct 27, 2020
che-bot
added
the
status/need-triage
An issue that needs to be prioritized by the curator responsible for the triage. See https://github.
label
Oct 27, 2020
ericwill
removed
the
status/need-triage
An issue that needs to be prioritized by the curator responsible for the triage. See https://github.
label
Oct 27, 2020
tolusha
added
the
severity/P2
Has a minor but important impact to the usage or development of the system.
label
Oct 28, 2020
18 tasks
@benoitf any objections to using a monorepo for sidecar images in quay.io? For example: This removes the dependency of needing a new quay.io repo for every sidecar image. |
no objection 👍 (any 'manual' step that can be removed is good (like creating quay.io repository and setting-up permissions) |
9 tasks
ericwill
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Nov 4, 2020
* Add sidecar PR check and build/push actions Prepare the plugin-registry for sidecar definition migration. Part of eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com> * Fix shellcheck Signed-off-by: Eric Williams <ericwill@redhat.com> * Fix dead code, disable SC2199 Signed-off-by: Eric Williams <ericwill@redhat.com> * Fixup Refactor script a bit, change runners, clean up copyrights. Signed-off-by: Eric Williams <ericwill@redhat.com>
This was referenced Nov 6, 2020
ericwill
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Nov 9, 2020
* Move sidecar definitions into the plugin registry Part 1 of the migration. I am doing it in parts because doing it all at once will likely cause a build timeout upon pushing. Part of eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com> * Handle java and java8 separately Signed-off-by: Eric Williams <ericwill@redhat.com>
This was referenced Nov 9, 2020
Closed
sideeffffect
pushed a commit
to sideeffffect/che-plugin-registry
that referenced
this issue
Nov 10, 2020
…he#676) * Move sidecar definitions into the plugin registry Part 1 of the migration. I am doing it in parts because doing it all at once will likely cause a build timeout upon pushing. Part of eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com> * Handle java and java8 separately Signed-off-by: Eric Williams <ericwill@redhat.com>
ericwill
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Nov 11, 2020
* Contribute remaining sidecar definitions to the plugin registry README/CONTRIBUTING update will follow in a separate PR. Part of eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com> * Split PR into smaller pieces for ease of build time Signed-off-by: Eric Williams <ericwill@redhat.com>
9 tasks
ericwill
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Nov 12, 2020
eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com>
9 tasks
ericwill
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Nov 12, 2020
Fixes eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com>
9 tasks
ericwill
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Nov 24, 2020
Part of eclipse-che/che#18217 Signed-off-by: Eric Williams <ericwill@redhat.com>
apupier
added a commit
to apupier/che-plugin-registry
that referenced
this issue
Dec 4, 2020
repository eclipse-che/che#18217 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
9 tasks
apupier
added a commit
to eclipse-che/che-plugin-registry
that referenced
this issue
Dec 4, 2020
repository eclipse-che/che#18217 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugin-registry
kind/task
Internal things, technical debt, and to-do tasks to be performed.
severity/P2
Has a minor but important impact to the usage or development of the system.
Is your task related to a problem? Please describe.
Currently, sidecars used in plug-ins are defined in the https://github.com/che-dockerfiles organisation.
It works pretty well for existing plug-ins but it make stuff complicated for contributing:
Contributor experience should be smoother allowing to:
Describe the solution you'd like
Allow to add sidecar definitions in the che-plugin-registry referencing the path where sidecar is defined.
example inside a chePlugin:
and in
sidecars/java11
folder:it could contain Dockerfile, entrypoint.sh, etc
Describe alternatives you've considered
Additional context
Lifecycle might be different between sidecars and plug-ins.
The text was updated successfully, but these errors were encountered: