Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chectl] Adding image puller support #18570

Closed
ibuziuk opened this issue Dec 9, 2020 · 6 comments
Closed

[chectl] Adding image puller support #18570

ibuziuk opened this issue Dec 9, 2020 · 6 comments
Labels
area/chectl Issues related to chectl, the CLI of Che area/image-puller Issues related to image-puller https://github.com/che-incubator/kubernetes-image-puller kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Dec 9, 2020

Is your task related to a problem? Please describe.

image puller was integrated into operatorhub installation flow as part of #18133

For the feature parity need to add the image-puller support to chectl CLI
@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/image-puller Issues related to image-puller https://github.com/che-incubator/kubernetes-image-puller area/chectl Issues related to chectl, the CLI of Che team/hosted-che labels Dec 9, 2020
@ibuziuk ibuziuk added this to the 7.24 milestone Dec 9, 2020
@tolusha
Copy link
Contributor

tolusha commented Dec 9, 2020

What does it actually mean?

@gattytto
Copy link

may this issue be related to #18569 ?

@tomgeorge
Copy link
Contributor

Right now, if you were to run chectl and pass in a CheCluster CR that has imagePuller.enabled set to true, it will fail. Ideally, chectl should take care of this for the user.

@tolusha
Copy link
Contributor

tolusha commented Dec 16, 2020

@tomgeorge
sorry, I didn't get ^(

@nickboldt nickboldt modified the milestones: 7.24, 7.25 Jan 8, 2021
@ibuziuk ibuziuk mentioned this issue Jan 19, 2021
Closed
@ibuziuk ibuziuk removed this from the 7.25 milestone Jan 19, 2021
@ibuziuk ibuziuk mentioned this issue Jun 18, 2021
Closed
@tolusha
Copy link
Contributor

tolusha commented Jul 16, 2021

@ibuziuk
Is it still relevant ?

@tolusha
Copy link
Contributor

tolusha commented Aug 17, 2021

I am closing this issue since chectl provides --che-operator-cr-patch-yaml flag to customize CheCluster CR

@tolusha tolusha closed this as completed Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/chectl Issues related to chectl, the CLI of Che area/image-puller Issues related to image-puller https://github.com/che-incubator/kubernetes-image-puller kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickboldt @gattytto @tomgeorge @ibuziuk @tolusha