Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we move to pnp/yarn 2 for some typescript projects ? #18571

Open
benoitf opened this issue Dec 9, 2020 · 3 comments
Open

Should we move to pnp/yarn 2 for some typescript projects ? #18571

benoitf opened this issue Dec 9, 2020 · 3 comments
Labels
area/dashboard area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Dec 9, 2020

Is your enhancement related to a problem? Please describe.

yarn 2 comes with pnp and zero-install.

we have some repositories like plugin-registry, dashboard, etc that could be converted to yarnv2/berry

Pro: it could avoid to download all dependencies after cloning the repositories and allow better 'downstreaming' as there would be no 'internet connection required' to grab npm dependencies

cons: it would make .yarn/pnp dependencies committed into the repository, thus making the repository bigger.

note: for che-theia, it's depending on upstream theia

Describe the solution you'd like

Wanted to hear feedback from people.
it's like the vendor/ for go committed or not :-)

Describe alternatives you've considered

We could switch only on downstream repositories

Additional context

@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 9, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 9, 2020
@benoitf benoitf added area/chectl Issues related to chectl, the CLI of Che area/dashboard area/plugin-registry labels Dec 9, 2020
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 9, 2020
@nickboldt
Copy link
Contributor

nickboldt commented Dec 9, 2020

Having ALL sources already committed to the upstream would make downstreaming WAY simpler as we wouldn't need to:

  • copy upstream to downstream, applying branding/transforms as needed
  • container build locally to fetch all the deps, using one variant of the Dockerfile (use internet to resolve deps)
  • tarball those deps
  • commit the tarball into the downstream repo
  • container build in Brew, using the fetched deps tarballs, using a second variant of the Dockerfile (build offline, unpacking tarball to get deps)

Instead we would have:

  • copy upstream to downstream, applying branding/transforms as needed, including vendored sources / dependencies
  • container build in Brew, using the deps already in the repo, using a single variant of the Dockerfile

So 100% in favour of this plan, for node/ts components that become images, and for chectl/crwctl too.

@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@che-bot che-bot closed this as completed Jun 18, 2021
@ericwill
Copy link
Contributor

AFAIK we still face issues with yarn v2 on s390x, so we are not doing this.

@ericwill ericwill reopened this Jun 18, 2021
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 18, 2021
@tolusha tolusha removed the area/chectl Issues related to chectl, the CLI of Che label Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/plugin-registry kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants