-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we move to pnp/yarn 2 for some typescript projects ? #18571
Comments
Having ALL sources already committed to the upstream would make downstreaming WAY simpler as we wouldn't need to:
Instead we would have:
So 100% in favour of this plan, for node/ts components that become images, and for chectl/crwctl too. |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
AFAIK we still face issues with yarn v2 on s390x, so we are not doing this. |
Is your enhancement related to a problem? Please describe.
yarn 2 comes with pnp and zero-install.
we have some repositories like plugin-registry, dashboard, etc that could be converted to yarnv2/berry
Pro: it could avoid to download all dependencies after cloning the repositories and allow better 'downstreaming' as there would be no 'internet connection required' to grab npm dependencies
cons: it would make .yarn/pnp dependencies committed into the repository, thus making the repository bigger.
note: for che-theia, it's depending on upstream theia
Describe the solution you'd like
Wanted to hear feedback from people.
it's like the vendor/ for go committed or not :-)
Describe alternatives you've considered
We could switch only on downstream repositories
Additional context
The text was updated successfully, but these errors were encountered: