Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert midstream repo to use upstream plugin registry automation #473

Conversation

ericwill
Copy link
Contributor

🚫 Do not merge until CRW 2.8 is released! 🚫

Signed-off-by: Eric Williams ericwill@redhat.com

What does this PR do?

Introduces the plugin registry automation from upstream into the midstream repository.

What issues does this PR fix or reference?

Part of CRW-1648

Release Notes

Docs PR (if applicable)

@ericwill ericwill requested a review from nickboldt April 12, 2021 19:18
@ericwill
Copy link
Contributor Author

This is a work in progress, not quite ready yet.

@benoitf
Copy link
Contributor

benoitf commented Apr 13, 2021

I think it will require eclipse-che/che#18571 (yarn2 enabling) to make it happy on offline brew

@ericwill
Copy link
Contributor Author

I think it will require eclipse/che#18571 (yarn2 enabling) to make it happy on offline brew

Yes I believe you are correct. Something for next sprint 👍

@nickboldt
Copy link
Member

+1 for whatever makes it easier to fetch deps into an offline cache for reuse in brew. go mod vendor is nice, and if yarn2 can do the same, that's awesome.

Part of CRW-1648

Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill ericwill force-pushed the 1648_plugin_registry_automation_no_version branch from 8197b75 to 14b1088 Compare April 28, 2021 19:32
@ericwill ericwill requested a review from benoitf April 28, 2021 19:33
Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
Signed-off-by: Eric Williams <ericwill@redhat.com>
@ericwill
Copy link
Contributor Author

Closing this and will reopen with a non-fork branch to get working CI.

@ericwill ericwill closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants