Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming Devfiles at the root of a git repository should be our first use case #18666

Closed
6 tasks
l0rd opened this issue Dec 18, 2020 · 1 comment
Closed
6 tasks
Labels
area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.

Comments

@l0rd
Copy link
Contributor

l0rd commented Dec 18, 2020

Is your enhancement related to a problem? Please describe.

Starting a workspace using a factory link and with a devfile at the root of the repository is the most used scenario but is not the main supported and tested one. The main supported and tested is the scenario where the devfile is published out of the git repository, in the devfile registry for example.

Describe the solution you'd like

  • Add v2 devfiles in the samples git repositories (whenever possible) Create v2 devfiles for Getting Started samples #19341
  • The devfile registry should only be a registry of parent devfiles
  • Update the happy path tests to use a devfile within a repository
  • Improve UX of common scenarios:
    • Password protected git repositories
    • Prompt user if git remotes (fork) and branch in devfile project do not match the factory link

Additional context

This work should be included in the context of che workspaces that use the DevWorkspace operator, so that's not for v1 devfiles.

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Dec 18, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 18, 2020
@yhontyk yhontyk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 18, 2020
@l0rd l0rd added area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ area/workspace-loader and removed severity/P1 Has a major impact to usage or development of the system. labels Dec 20, 2020
@l0rd l0rd added this to the DevWorkspace Integration - STEP2 milestone Mar 5, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Apr 8, 2021

Closing as this is already tracked in #19341

@l0rd l0rd closed this as completed Apr 8, 2021
@l0rd l0rd removed this from the DevWorkspace Integration - STEP2 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/getting-started Issues related to the getting started samples https://www.eclipse.org/che/getting-started/cloud/ engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed.
Projects
None yet
Development

No branches or pull requests

4 participants