Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v2 devfiles for Getting Started samples #19341

Closed
4 of 5 tasks
Tracked by #20830
l0rd opened this issue Mar 19, 2021 · 6 comments
Closed
4 of 5 tasks
Tracked by #20830

Create v2 devfiles for Getting Started samples #19341

l0rd opened this issue Mar 19, 2021 · 6 comments
Assignees
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. sprint/current

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 19, 2021

Is your enhancement related to a problem? Please describe.

One of the sub-epics of Run Che workspaces using the DevWorkspace operator is to switch our samples from a v1 to v2 based devfiles.

Describe the solution you'd like

  • Add v2 devfiles in our samples git repositories
  • Implement a new "project samples" registry, alternative to the devfile registry
  • Add a installation parameter to switch between devfile and sample registry as the source of the getting started samples
  • Adapt tests to use devfile v2 based Getting Started samples

Related to #18666

Further details

A simple devfile v2 is the one available here.
We should use schemaVersion: 2.1.0 rather than schemaVersion: 2.0.0 (che-server support for it)
and the full updated reference is here.

Subtasks

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 19, 2021
@l0rd l0rd added this to the DevWorkspace Integration - STEP2 milestone Mar 19, 2021
@l0rd l0rd added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/dashboard labels Mar 19, 2021
@l0rd l0rd added the roadmap/3-months Epics that are planned to complete in the short term (within 3 months) label Mar 26, 2021
@l0rd l0rd changed the title Create v2 Devfiles for Getting Started samples Create new Devfiles based on v2 of the spec for current Che Getting Started samples Mar 29, 2021
@l0rd l0rd changed the title Create new Devfiles based on v2 of the spec for current Che Getting Started samples Create new v2 devfiles for current Che Getting Started samples Mar 29, 2021
@sympatheticmoose sympatheticmoose added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Mar 31, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Jun 14, 2021

Moving it out of scope of STEP 2 of the devworkspace work as we won't be able to create all the samples devfiles. That will be postponed to STEP 3 and we need to discuss if we need to update the devfile samples.

@svor
Copy link
Contributor

svor commented Oct 29, 2021

@apupier @sideeffffect @filipkroupa @AndrienkoAleksandr we are creating devfiles v2 for getting started samples (more information you can find in the description).
It's already done for some samples, you can check the progress in the spreadsheet. So, I'd like to ask you to take care about the samples which you have contributed.

The procedure should be:

  • Create a new branch in sample's repository (if you don't have permissions ask me)
  • Add devfile.yaml version 2. Here you can find Devfile V2 API, also you can look at existing devfile v2 for quarkus sample
  • Add the link to the branch with devfile v2 into meta.yaml in che-devfile-registry, for example take a look at quarkus meta.yaml

If you have any question, please ask me.

@sideeffffect
Copy link

@svor here are the PRs for Scala/Metals:

@max-cx
Copy link

max-cx commented Nov 15, 2021

Hi, a question to the assignee of this issue:

Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide?

Yes/No?

benoitf added a commit to benoitf/che-devfile-registry that referenced this issue Dec 9, 2021
part of eclipse-che/che#19341

Change-Id: I98a708ba9a9dd8debe02fd9c0fd7e12b0cd212fe
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to eclipse-che/che-devfile-registry that referenced this issue Dec 10, 2021
part of eclipse-che/che#19341

Change-Id: I98a708ba9a9dd8debe02fd9c0fd7e12b0cd212fe
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@svor
Copy link
Contributor

svor commented Dec 17, 2021

I'm going to close this issue. The following tasks were created:

@svor svor closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. sprint/current
Projects
None yet
Development

No branches or pull requests

7 participants