Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new link entries in devfile registry for devfile v2 #19906

Closed
benoitf opened this issue Jun 2, 2021 · 1 comment
Closed

Add new link entries in devfile registry for devfile v2 #19906

benoitf opened this issue Jun 2, 2021 · 1 comment
Labels
area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Jun 2, 2021

Is your task related to a problem? Please describe.

For now, we have meta.yaml with self links pointing to devfile.yaml
For devfile v2, we'll need to have links to v2 devfiles. But also as the idea is to be "repository first" instead of "devfile first", the links should be pointers to repositories.

Describe the solution you'd like

Add v2 links in addition to the self-links.

for example

"v2": "http://github.com/my/repository/tree/1.x"

to use the 1.x branch of this git repository

Describe alternatives you've considered

Additional context

as part of #19718, some other entries would be defined like

prebuilt: 
   - "che-theia/next": "/path/to/all-in-one-che-theia-next.yaml"
   - "che-theia/latest": "/path/to/all-in-one-che-theia-latest.yaml"
   - "intellij/latest": "/path/to/all-in-one-intellij-latest.yaml"

For offline builds, we may still need to copy the repository devfile.yaml instead of using repository link

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. area/devfile-registry labels Jun 2, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 2, 2021
benoitf added a commit to benoitf/che-devfile-registry that referenced this issue Jun 2, 2021
For now add only one entry for spring petclinic
related to eclipse-che/che#19906

Change-Id: I769f8013065249674b35748176ef8acdf847f671
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/che-devfile-registry that referenced this issue Jun 2, 2021
For now add only one entry for spring petclinic
related to eclipse-che/che#19906

Change-Id: I769f8013065249674b35748176ef8acdf847f671
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@ericwill ericwill added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 2, 2021
benoitf added a commit to eclipse-che/che-devfile-registry that referenced this issue Jun 3, 2021
For now add only one entry for spring petclinic
related to eclipse-che/che#19906

Change-Id: I769f8013065249674b35748176ef8acdf847f671
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Contributor Author

benoitf commented Jun 9, 2021

Fixed by eclipse-che/che-devfile-registry#408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants