Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

fix: update all devWorkspace templates #556

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 17, 2021

What does this PR do?

Fix INTERNAL_URL not being updated for che-code templates

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19906

How to test this PR?

Build the image, run the container with something like

$ docker run --rm -it -e CHE_DEVFILE_REGISTRY_URL=http://foo.bar -e CHE_DEVFILE_REGISTRY_INTERNAL_URL=http://another.baz -p 8080:8080 quay.io/eclipse/che-devfile-registry:next

And see that the INTERNAL_URL of the zip inside checode template has been updated

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

not only che-theia one

Change-Id: I6faeeb17c33b2d108694bda11264f0dfff59a370
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@svor svor merged commit 84c47ab into eclipse-che:main Dec 17, 2021
@che-bot che-bot added this to the 7.41 milestone Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants