Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard next does not need its own loader #18734

Closed
sleshchenko opened this issue Jan 5, 2021 · 2 comments
Closed

Dashboard next does not need its own loader #18734

sleshchenko opened this issue Jan 5, 2021 · 2 comments
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Jan 5, 2021

Describe the bug

As far as I understand after @akurinnoy told me, Dashboard Next shows loader until it receives the event from IDE that it's ready. But:

  1. It makes an impression that it takes more time for IDE to be opened in the Dashboard Next.
  2. It makes it impossible to open IDE that does not send event (I assume jupyter and Intelij are such)

So, when Dashboard Next opens an IDE in an iframe, it does not need to show its own loading but instead of it should just display what iframe has: loader.js UI and then Theia UI ( that has its own loader as well).

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/dashboard labels Jan 5, 2021
@sleshchenko sleshchenko added this to the 7.25 milestone Jan 12, 2021
@akurinnoy akurinnoy self-assigned this Jan 13, 2021
@akurinnoy
Copy link
Contributor

It makes it impossible to open IDE that does not send event (I assume jupyter and Intelij are such)

I missed it previously but figured it now: there is a 1 minute timeout until iframe content is shown if there are no event from iframe. But still an editor may load much faster than that timeout ends, so user have to wait.

@sleshchenko
Copy link
Member Author

Is implemented in eclipse-che/che-dashboard#142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants