Remove redundant loader #142

akurinnoy · 2021-01-22T14:36:06Z

What does this PR do?

This PR removes redundant loader that hides the IDE iframe while IDE is loading.

What issues does this PR fix or reference?

eclipse-che/che#18734

che-bot · 2021-01-22T14:43:38Z

❌ E2E dashboard-next tests failed ❗

See Details

Jenkins job
test report
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

github-actions · 2021-01-22T14:51:05Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-142

Ohrimenko1988 · 2021-01-25T09:34:00Z

[dashboard-next-ci-test]

che-bot · 2021-01-25T10:29:21Z

❌ E2E dashboard-next tests failed ❗

See Details

Jenkins job
test report
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

Ohrimenko1988 · 2021-01-25T12:50:44Z

[dashboard-next-ci-test]

che-bot · 2021-01-25T13:14:50Z

✅ E2E dashboard-next tests succeed 🎉

See Details

Jenkins job
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

github-actions · 2021-01-26T12:22:52Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-142

che-bot · 2021-01-26T12:31:27Z

✅ E2E dashboard-next tests succeed 🎉

See Details

Jenkins job
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

JPinkney

I just have a few minor comments. I tried on che.openshift.io and everything is working perfectly but when I tried locally with my own che instance I got:

Refused to frame 'https://keycloak-eclipse-che.apps-crc.testing/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self'".

when the workspace is trying to open. If I click away and then re-open the workspace it works though.

Also, I'm not sure if it's related to this PR but the workspace logs no longer reset after a workspace has been stopped then restarted again

src/containers/__tests__/IdeLoader.spec.tsx

webpack.config.common.js

olexii4

LGTM

che-bot · 2021-01-28T09:44:25Z

✅ E2E dashboard-next tests succeed 🎉

See Details

Jenkins job
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

github-actions · 2021-01-28T11:56:54Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-142

github-actions · 2021-01-28T12:00:43Z

Code coverage diff between base branch:master and head branch: redundant-loader-2

File	% Stmts	% Branch	% Funcs	% Lines
total	~~51.49~~ 51.7	~~35.81~~ 36.12	~~50.94~~ 51.09	~~51.42~~ 51.6
src/containers/IdeLoader.tsx	~~68.06~~ 67.32	~~68.32~~ 66.04	~~74.07~~ 74.07	~~67.83~~ 67.11
src/pages/IdeLoader/index.tsx	~~47.27~~ 62.96	~~33.71~~ 44.62	~~36.84~~ 50	~~48.6~~ 63.75
src/store/Environment/index.ts	0	0	0	0
src/store/Environment/selectors.ts	100	100	100	100

github-actions · 2021-01-28T12:04:00Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-142

che-bot · 2021-01-28T12:48:45Z

✅ E2E dashboard-next tests succeed 🎉

See Details

Jenkins job
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

akurinnoy · 2021-01-28T14:30:45Z

@JPinkney

I tried on che.openshift.io and everything is working perfectly but when I tried locally with my own che instance I got:

Refused to frame 'https://keycloak-eclipse-che.apps-crc.testing/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self'".

when the workspace is trying to open. If I click away and then re-open the workspace it works though.

You need to completely close your browser and try it again. I hope it will help.

Also, I'm not sure if it's related to this PR but the workspace logs no longer reset after a workspace has been stopped then restarted again

I see the same with current master branch, so I filed an issue.

added detection of working environment as well Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

github-actions · 2021-01-29T13:43:05Z

Code coverage diff between base branch:master and head branch: redundant-loader-2

File	% Stmts	% Branch	% Funcs	% Lines
total	~~51.32~~ 51.63	~~35.76~~ 36.09	~~50.78~~ 50.88	~~51.25~~ 51.53
src/containers/IdeLoader.tsx	~~68.06~~ 67.52	~~68.32~~ 65.74	~~74.07~~ 74.07	~~67.83~~ 67.31
src/pages/IdeLoader/index.tsx	~~47.27~~ 62.96	~~33.71~~ 44.62	~~36.84~~ 50	~~48.6~~ 63.75
src/services/storageTypes.ts	75 75.44	~~61.11~~ 61.11	~~87.5~~ 87.5	75 75.44
src/services/keycloak/setup.ts	11.71	0	0	10.19
src/store/Environment/index.ts	25	0	0	25
src/store/Environment/selectors.ts	100	100	100	100

github-actions · 2021-01-29T13:46:55Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-142

che-bot · 2021-01-29T13:49:44Z

❌ E2E dashboard-next tests failed ❗

See Details

Jenkins job
test report
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:142
Che server image: docker.io/maxura/che-server:142

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

Ohrimenko1988 · 2021-02-01T10:25:34Z

[dashboard-next-ci-test]

sleshchenko

I did not review code carefully but docker.io/maxura/che-server:che-dashboard-pull-142 seems to work as expected.
I even tried IntelijEditor

intelij-java-web-vertx.devfile.yaml

apiVersion: 1.0.0
metadata:
  name: intelij-java-web-vertx
projects:
  - name: vertx-http-example
    source:
      location: 'https://github.com/openshift-vertx-examples/vertx-http-example.git'
      type: git
      branch: master
components:
  - id: che-incubator/intellij-community/latest
    type: cheEditor
  - mountSources: true
    endpoints:
      - name: 8080-tcp
        port: 8080
      - attributes:
          public: 'false'
        name: debug
        port: 5005
    memoryLimit: 512Mi
    type: dockerimage
    volumes:
      - name: m2
        containerPath: /home/user/.m2
    alias: maven
    image: 'quay.io/eclipse/che-java8-maven:nightly'
    env:
      - value: ''
        name: MAVEN_CONFIG
      - value: '-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -Dsun.zip.disableMemoryMapping=true -Xms20m -Djava.security.egd=file:/dev/./urandom -Duser.home=/home/user'
        name: JAVA_OPTS
      - value: $(JAVA_OPTS)
        name: MAVEN_OPTS
commands:
  - name: maven build
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/vertx-http-example'
        type: exec
        command: 'mvn -Duser.home=${HOME} clean install'
        component: maven
  - name: run app
    actions:
      - workdir: '${CHE_PROJECTS_ROOT}/vertx-http-example'
        type: exec
        command: |
          JDBC_URL=jdbc:h2:/tmp/db \
          java -jar -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=5005 \
          ./target/*.jar
        component: maven
  - name: stop app
    actions:
      - type: exec
        command: echo 'Stopping the application...' && kill $(pidof java) && echo 'The application has been successfully stopped'
        component: maven
  - name: Debug remote java application
    actions:
      - referenceContent: |
          {
          "version": "0.2.0",
          "configurations": [
            {
              "type": "java",
              "name": "Debug (Attach) - Remote",
              "request": "attach",
              "hostName": "localhost",
              "port": 5005
            }]
          }
        type: vscode-launch

Ohrimenko1988 · 2021-02-01T12:12:09Z

[dashboard-next-ci-test]

akurinnoy requested review from sleshchenko and olexii4 January 22, 2021 14:36

akurinnoy self-assigned this Jan 22, 2021

This comment has been minimized.

Sign in to view

akurinnoy requested a review from JPinkney January 26, 2021 12:11

This comment has been minimized.

Sign in to view

JPinkney reviewed Jan 26, 2021

View reviewed changes

src/containers/__tests__/IdeLoader.spec.tsx Outdated Show resolved Hide resolved

webpack.config.common.js Outdated Show resolved Hide resolved

olexii4 reviewed Jan 27, 2021

View reviewed changes

webpack.config.common.js Outdated Show resolved Hide resolved

olexii4 approved these changes Jan 27, 2021

View reviewed changes

akurinnoy force-pushed the redundant-loader-2 branch from 7109c78 to 74cf80a Compare January 28, 2021 11:43

This comment has been minimized.

Sign in to view

akurinnoy added 4 commits January 28, 2021 19:59

remove redundant loader

b9156e5

made possible to open IDE in iframe while serving dashboard locally

76d0751

added detection of working environment as well Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

removed dependency @patternfly/patternfly, updated license-tool

0688f5a

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

fixes

28e3c65

akurinnoy force-pushed the redundant-loader-2 branch from c2c4640 to 28e3c65 Compare January 29, 2021 13:33

sleshchenko approved these changes Feb 1, 2021

View reviewed changes

akurinnoy merged commit 655309f into master Feb 1, 2021

akurinnoy deleted the redundant-loader-2 branch February 1, 2021 15:19

sleshchenko mentioned this pull request Feb 2, 2021

Dashboard next does not need its own loader eclipse-che/che#18734

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove redundant loader #142

Remove redundant loader #142

akurinnoy commented Jan 22, 2021

che-bot commented Jan 22, 2021

This comment has been minimized.

github-actions bot commented Jan 22, 2021

Ohrimenko1988 commented Jan 25, 2021

che-bot commented Jan 25, 2021

Ohrimenko1988 commented Jan 25, 2021

che-bot commented Jan 25, 2021

This comment has been minimized.

github-actions bot commented Jan 26, 2021

che-bot commented Jan 26, 2021

JPinkney left a comment

olexii4 left a comment

che-bot commented Jan 28, 2021

This comment has been minimized.

github-actions bot commented Jan 28, 2021

github-actions bot commented Jan 28, 2021

github-actions bot commented Jan 28, 2021

che-bot commented Jan 28, 2021

akurinnoy commented Jan 28, 2021

github-actions bot commented Jan 29, 2021

github-actions bot commented Jan 29, 2021

che-bot commented Jan 29, 2021

Ohrimenko1988 commented Feb 1, 2021

sleshchenko left a comment

Ohrimenko1988 commented Feb 1, 2021

Remove redundant loader #142

Remove redundant loader #142

Conversation

akurinnoy commented Jan 22, 2021

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Jan 22, 2021

This comment has been minimized.

github-actions bot commented Jan 22, 2021

Ohrimenko1988 commented Jan 25, 2021

che-bot commented Jan 25, 2021

Ohrimenko1988 commented Jan 25, 2021

che-bot commented Jan 25, 2021

This comment has been minimized.

github-actions bot commented Jan 26, 2021

che-bot commented Jan 26, 2021

JPinkney left a comment

Choose a reason for hiding this comment

olexii4 left a comment

Choose a reason for hiding this comment

che-bot commented Jan 28, 2021

This comment has been minimized.

github-actions bot commented Jan 28, 2021

github-actions bot commented Jan 28, 2021

github-actions bot commented Jan 28, 2021

che-bot commented Jan 28, 2021

akurinnoy commented Jan 28, 2021

github-actions bot commented Jan 29, 2021

github-actions bot commented Jan 29, 2021

che-bot commented Jan 29, 2021

Ohrimenko1988 commented Feb 1, 2021

sleshchenko left a comment

Choose a reason for hiding this comment

Ohrimenko1988 commented Feb 1, 2021