-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export launch configurations from devfile to workspace config file #18866
Labels
area/plugins
kind/task
Internal things, technical debt, and to-do tasks to be performed.
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
severity/P1
Has a major impact to usage or development of the system.
Milestone
Comments
RomanNikitenko
added
kind/task
Internal things, technical debt, and to-do tasks to be performed.
severity/P1
Has a major impact to usage or development of the system.
area/plugins
labels
Jan 22, 2021
15 tasks
Closed
9 tasks
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
che-bot
added
the
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
label
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/plugins
kind/task
Internal things, technical debt, and to-do tasks to be performed.
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
severity/P1
Has a major impact to usage or development of the system.
The issue depends on:
The first one is critical for the current issue.
Is your task related to a problem? Please describe.
At the moment launch configurations are exported from the
devfile
to the config filelaunch.json
in the/workspaceFolder/.theia
directory. I don't see any problems for the current behavior, because:projects
projects
contains all exported fromdevfile
projectslaunch
configs placed in/projects/.theia/launch.json
file - so - no changes for imported projectslaunch
configs are available for running for any imported projectWe are going to support Multi-root Che Theia Workspaces by default, please see #17212
We get automatically the following behavior for multi-root workspaces if we don't provide any changes related to mechanism of exporting launch configurations:
projects
is not workspace folder now - each imported project is a workspace folder,number imported projects = number workspace folders
devfile
to each workspace folder, so they are duplicated for each imported projectlaunch.json
launch.json
Describe the solution you'd like
My propose is exporting launch configurations from devfile to workspace config file, so on workspace level.
Using such approach we could avoid:
/projects/.theia/launch.json
file (a project for cloning contains own configs vs configs from devfile)Please see explanation above ^^.
Describe alternatives you've considered
Additional context
The issue depends on:
The first one is critical for the current issue.
The text was updated successfully, but these errors were encountered: