Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export launch configurations from devfile to workspace config file #18866

Closed
Tracked by #19958
RomanNikitenko opened this issue Jan 22, 2021 · 1 comment
Closed
Tracked by #19958
Assignees
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jan 22, 2021

The issue depends on:

The first one is critical for the current issue.

Is your task related to a problem? Please describe.

At the moment launch configurations are exported from the devfile to the config file launch.json in the /workspaceFolder/.theia directory. I don't see any problems for the current behavior, because:

  • workspace folder by default is projects
  • projects contains all exported from devfile projects
  • launch configs placed in /projects/.theia/launch.json file - so - no changes for imported projects
  • launch configs are available for running for any imported project

We are going to support Multi-root Che Theia Workspaces by default, please see #17212
We get automatically the following behavior for multi-root workspaces if we don't provide any changes related to mechanism of exporting launch configurations:

  • projects is not workspace folder now - each imported project is a workspace folder,
    number imported projects = number workspace folders
  • launch configurations are exported from the devfile to each workspace folder, so they are duplicated for each imported project
  • after exporting the configurations the workspace has unstaged changes for each workspace folder, so, for example:
    • theia/.theia.launch.json
    • che-theia/.theia.launch.json

Describe the solution you'd like

My propose is exporting launch configurations from devfile to workspace config file, so on workspace level.
Using such approach we could avoid:

  • unstaged git changes for each imported project,
  • configuration duplication for each imported project
  • conflicts with existing configs in /projects/.theia/launch.json file (a project for cloning contains own configs vs configs from devfile)

Please see explanation above ^^.

Describe alternatives you've considered

Additional context

The issue depends on:

The first one is critical for the current issue.

@RomanNikitenko RomanNikitenko added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. area/plugins labels Jan 22, 2021
@azatsarynnyy azatsarynnyy added this to the 7.29 milestone Mar 24, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Mar 24, 2021
12 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.29, 7.30 Apr 8, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Apr 9, 2021
8 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.30, 7.31 Apr 27, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Apr 27, 2021
11 tasks
@azatsarynnyy azatsarynnyy mentioned this issue May 20, 2021
14 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.31, 7.32 May 26, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Jun 10, 2021
10 tasks
@azatsarynnyy azatsarynnyy modified the milestones: 7.32, 7.33 Jun 16, 2021
@che-bot
Copy link
Contributor

che-bot commented Mar 9, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2022
@che-bot che-bot closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants