Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace-scoped launch configurations of multi-root workspace are associated with folders #8985

Open
Tracked by #19958
RomanNikitenko opened this issue Jan 25, 2021 · 2 comments
Assignees
Labels
bug bugs found in the application debug issues that related to debug functionality Team: Che-Editors issues regarding the che-editors team
Milestone

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Jan 25, 2021

Bug Description:

At the moment Theia duplicates Workspace launch configs at displaying on Debug panel for every project of multi-root workspace.
For example, user has workspace config file like:

{
    "folders": [
        {
            "path": "theia"
        },
        {
            "path": "vscode"
        }
    ],
    "settings": {
        "launch": {
            "configurations": [
                {
                    "name": "Launch Chrome",
                    "request": "launch",
                    "type": "pwa-chrome",
                    "url": "http://localhost:8080",
                    "webRoot": "${workspaceFolder}"
                }
            ]
        }
    }
}

So, there are 2 projects and only one launch configuration.
The configuration is displayed twice on the Debug panel (once per each workspace folder - so for theia and for vscode in my example above):

theia-launch

VS Code doesn't associate workspace level configs with a particular folder :

vscode_launch

Steps to Reproduce:

  1. Start a multi-root workspace from config file with launch configurations (please see the example above)
  2. Go to the Debug panel and check the workspace level configs

Additional Information

  • Operating System: Fedora 31
  • Theia Version: 4204297
@RomanNikitenko RomanNikitenko added enhancement issues that are enhancements to current functionality - nice to haves debug issues that related to debug functionality labels Jan 25, 2021
@RomanNikitenko
Copy link
Contributor Author

RomanNikitenko commented Jan 26, 2021

I created the issue as enhancement, because I thought the current behavior is the result of the first implementation of launch configs in Theia without alignment of the behavior with VS Code.

But after seeing the comment for me it looks like a bug and the investigation contains some details related to the cause of the problem.

@RomanNikitenko RomanNikitenko changed the title Improve behavior for Workspace launch configurations of multi-root workspace Workspace-scoped launch configurations of multi-root workspace are associated with folders Jan 26, 2021
@RomanNikitenko RomanNikitenko added bug bugs found in the application and removed enhancement issues that are enhancements to current functionality - nice to haves labels Jan 26, 2021
@RomanNikitenko
Copy link
Contributor Author

Theia has similar problem for Global launch configurations, please see #8830 (comment)

@azatsarynnyy azatsarynnyy added che/next-sprint issues are planned for the next sprint by Che teams Team: Che-Editors issues regarding the che-editors team labels Apr 8, 2021
@azatsarynnyy azatsarynnyy added this to the 1.13.0 milestone Apr 8, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 1.13.0, 1.14.0 Apr 13, 2021
@azatsarynnyy azatsarynnyy added che/current-sprint issues taken to the current sprint by Che teams and removed che/next-sprint issues are planned for the next sprint by Che teams labels Apr 14, 2021
@azatsarynnyy azatsarynnyy added the che/next-sprint issues are planned for the next sprint by Che teams label Apr 27, 2021
@RomanNikitenko RomanNikitenko self-assigned this May 25, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 1.14.0, 1.15.0 May 26, 2021
@azatsarynnyy azatsarynnyy removed the che/next-sprint issues are planned for the next sprint by Che teams label May 26, 2021
@azatsarynnyy azatsarynnyy added the che/next-sprint issues are planned for the next sprint by Che teams label Jun 10, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 1.15.0, 1.16.0 Jun 16, 2021
@azatsarynnyy azatsarynnyy removed the che/next-sprint issues are planned for the next sprint by Che teams label Jun 16, 2021
@azatsarynnyy azatsarynnyy added che/next-sprint issues are planned for the next sprint by Che teams and removed che/next-sprint issues are planned for the next sprint by Che teams labels Jun 30, 2021
@azatsarynnyy azatsarynnyy added the che/next-sprint issues are planned for the next sprint by Che teams label Jul 22, 2021
@azatsarynnyy azatsarynnyy modified the milestones: 1.16.0, Next Jul 28, 2021
@azatsarynnyy azatsarynnyy removed che/current-sprint issues taken to the current sprint by Che teams che/next-sprint issues are planned for the next sprint by Che teams labels Jul 28, 2021
@azatsarynnyy azatsarynnyy added the che/next-sprint issues are planned for the next sprint by Che teams label Sep 3, 2021
@azatsarynnyy azatsarynnyy removed the che/next-sprint issues are planned for the next sprint by Che teams label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality Team: Che-Editors issues regarding the che-editors team
Projects
None yet
Development

No branches or pull requests

2 participants