Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

happy path test against DWO should take into account manifests changing #19643

Closed
sleshchenko opened this issue Apr 22, 2021 · 0 comments
Closed
Assignees
Labels
area/qe engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@sleshchenko
Copy link
Member

Is your task related to a problem? Please describe.

Currently, happy path test against DWO run just tests with chectl embedded deployment manifests, which:

  • may not work due container needs updated manifests;
  • may work but hide regression since CRD is used from master.

It's needed to prepare manifests folder chectl where the current PR deployment manifests will be present, like che operator happy path test already does eclipse-che/che-operator@3c1dafe

Note that some PRs like devfile/devworkspace-operator#391 also depend on DevWorkspace Che Operator, which means - we should build it for PR check as well, if https://github.com/che-incubator/devworkspace-che-operator has the same branch name.
Otherwise we won't have another option than just ignore happy path test in such cases, after manually testing.

@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/qe severity/P1 Has a major impact to usage or development of the system. labels Apr 22, 2021
@rhopp rhopp added this to the 7.31 milestone Apr 30, 2021
@SkorikSergey SkorikSergey added the status/in-progress This issue has been taken by an engineer and is under active development. label May 12, 2021
@SkorikSergey SkorikSergey removed the status/in-progress This issue has been taken by an engineer and is under active development. label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qe engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants