Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devworkspace controller should not be in charge of routing suffix for DWR CRs #391

Merged
merged 2 commits into from
May 18, 2021
Merged

devworkspace controller should not be in charge of routing suffix for DWR CRs #391

merged 2 commits into from
May 18, 2021

Conversation

tinakurian
Copy link
Contributor

@tinakurian tinakurian commented Apr 19, 2021 •
edited by sleshchenko
Loading

What does this PR do?

Removes the routingSuffix. It should be assigned by the DWR controller.

It should be merged in sync with che-incubator/devworkspace-che-operator#45

What issues does this PR fix or reference?

#373

Is it tested? How?

Ran unit tests.

@tinakurian
Copy link
Contributor Author

/test v7-devworkspaces-operator-e2e

@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2021

@tinakurian: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sleshchenko sleshchenko changed the title devworkspace controller should create routing with empty host devworkspace controller should not be in charge of routing suffix for DWR CRs Apr 20, 2021
@sleshchenko sleshchenko requested a review from metlos April 20, 2021 13:17
@sleshchenko sleshchenko changed the title devworkspace controller should not be in charge of routing suffix for DWR CRs [WIP] devworkspace controller should not be in charge of routing suffix for DWR CRs Apr 20, 2021
sleshchenko
sleshchenko approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but with the latest changes it should work, and it should change nothing for DWCO, but still DWCO probably needs adaptation to remove routingSuffix read from DWR CR

@sleshchenko sleshchenko mentioned this pull request Apr 20, 2021
Closed
amisevsk
amisevsk approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I didn't test directly)

apis/controller/v1alpha1/devworkspacerouting_types.go
Comment on lines -28 to -29
// Routing suffix for cluster
RoutingSuffix string `json:"routingSuffix"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that this is a breaking change for v1alpha1 devworkspaceroutings, but I don't think it impacts anything as nothing is deploying devworkspaceroutings yet.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, metlos, sleshchenko, tinakurian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [amisevsk,sleshchenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sleshchenko sleshchenko mentioned this pull request Apr 22, 2021
Closed
@sleshchenko sleshchenko mentioned this pull request May 11, 2021
Closed
@sleshchenko sleshchenko changed the title [WIP] devworkspace controller should not be in charge of routing suffix for DWR CRs devworkspace controller should not be in charge of routing suffix for DWR CRs May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label May 18, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 18, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, metlos, sleshchenko, tinakurian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [amisevsk,sleshchenko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sleshchenko
Copy link
Member

rebased against main branch to run e2e tests on fresh version

@sleshchenko
Copy link
Member

/test v7-devworkspaces-operator-e2e

@sleshchenko sleshchenko merged commit 698baff into devfile:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metlos metlos metlos approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@amisevsk amisevsk amisevsk approved these changes

@JPinkney JPinkney Awaiting requested review from JPinkney

Assignees

@metlos metlos

@sleshchenko sleshchenko

@amisevsk amisevsk

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tinakurian @openshift-ci-robot @sleshchenko @metlos @amisevsk