Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JAR download from vscode-xml vsix build #19662

Closed
ericwill opened this issue Apr 22, 2021 · 0 comments · Fixed by eclipse-che/che-plugin-registry#955
Closed

Remove JAR download from vscode-xml vsix build #19662

ericwill opened this issue Apr 22, 2021 · 0 comments · Fixed by eclipse-che/che-plugin-registry#955
Assignees
@ericwill
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current sprint/next
Milestone
7.31

Comments

@ericwill
Copy link
Contributor

Is your task related to a problem? Please describe.

In the vscode-xml builder we download a server JAR. This is no longer needed as the server jar is packaged into the build by default, or at least it should be.

Describe the solution you'd like

Try with the upstream built vscode-xml and see if the issue is fixed. If so, we can probably remove our custom build process.

Describe alternatives you've considered

N/A

Additional context

This should also prevent the warning about untrusted binaries.
@ericwill ericwill added kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/next area/plugins labels Apr 22, 2021
@ericwill ericwill added this to the 7.31 milestone Apr 22, 2021
@ericwill ericwill self-assigned this Apr 22, 2021
@ericwill ericwill mentioned this issue Apr 29, 2021
Closed
32 tasks
@ericwill ericwill mentioned this issue May 13, 2021
Merged
9 tasks
ericwill added a commit to eclipse-che/che-plugin-registry that referenced this issue May 17, 2021
@ericwill
Add vscode-xml's server binary as a trusted setting (#955)
48c5ed1 
Fixes eclipse-che/che#19662

Signed-off-by: Eric Williams <ericwill@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwill ericwill

Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current sprint/next
Projects
None yet
Milestone
7.31
Development

Successfully merging a pull request may close this issue.

Add vscode-xml's server binary as a trusted setting
1 participant
@ericwill