Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevWorkspace must not be created if default plugins fails to load #19852

Closed
23 tasks
sleshchenko opened this issue May 21, 2021 · 0 comments · Fixed by eclipse-che/che-dashboard#303
Closed
23 tasks
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@sleshchenko
Copy link
Member

Describe the bug

DevWorkspace must not be created if default plugins fails to load.
Currently, when dashboard fails to load plugins, it creates DevWorkspace without any DevWorkspaceTemplates, which means - no Theia is injected.
Dashboard must not create DevWorkspace without default plugins being injected, since it does not make sense since it will lead to can not evaluate workspace main URL since theia is missing.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Configure https://che-plugin-registry-main.surge.sh/v3 to be used as external plugin registry.
  2. Dashboard is going to fail to load that since it has CORS restrictions.
  3. Try to create DevWorkspace.

Actual behavior: DevWorkspace is created but failed to open.

Expected behavior

Users to told that plugin registry does not have configured default plugins.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants