Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins view must display proper icons if plugins were installed from third-party registry (registryUrl: ...) #19898

Closed
1 task done
vitaliy-guliy opened this issue Jun 1, 2021 · 1 comment
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Jun 1, 2021

Describe the bug

Plugins view displays wrong icon if the plugin was added to the devfile with custom registryUrl

  - type: chePlugin
    id: che-incubator/typescript/latest
    registryUrl: https://eclipse-che.github.io/che-plugin-registry/7.31.0/v3/

Event if the plugins view displays some icon, it needs to ensure, that the icon refers on specific registry.

Che version

  • nightly

Steps to reproduce

  1. Create workspace from the devfile
apiVersion: 1.0.0
metadata:
  generateName: nodejs-web-app-
projects:
  - name: react-web-app
    source:
      type: git
      location: https://github.com/che-samples/react-web-app
components:
  - type: chePlugin
    id: editorconfig/editorconfig/0.14.4
    registryUrl: http://custom-plugin-registry.surge.sh/path/to/registry/v3/
  - type: dockerimage
    alias: nodejs
    image: quay.io/eclipse/che-nodejs12-community:7.31.0
    memoryLimit: 1500Mi
    endpoints:
      - name: nodejs
        port: 3000
    mountSources: true
commands:
  - name: 1. Install Yarn 2
    actions:
      - type: exec
        component: nodejs
        command: yarn set version berry
        workdir: ${CHE_PROJECTS_ROOT}/react-web-app
  - name: 2. Install all required dependencies
    actions:
      - type: exec
        component: nodejs
        command: yarn install
        workdir: ${CHE_PROJECTS_ROOT}/react-web-app
  - name: 3. Build the app
    actions:
      - type: exec
        component: nodejs
        command: yarn build
        workdir: ${CHE_PROJECTS_ROOT}/react-web-app
  - name: 4. Run the app
    actions:
      - type: exec
        component: nodejs
        command: yarn start
        workdir: ${CHE_PROJECTS_ROOT}/react-web-app
  - name: 5. Launch tests
    actions:
      - type: exec
        component: nodejs
        command: yarn test
        workdir: ${CHE_PROJECTS_ROOT}/react-web-app
  1. Open plugin view and check the icon of editorconfig/editorconfig/0.14.4 plugin.
@vitaliy-guliy vitaliy-guliy added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins severity/P2 Has a minor but important impact to the usage or development of the system. area/plugins labels Jun 1, 2021
@ericwill ericwill added severity/P1 Has a major impact to usage or development of the system. sprint/current and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Jun 1, 2021
@ericwill ericwill mentioned this issue Jun 8, 2021
29 tasks
@vinokurig
Copy link
Contributor

fixed by the PR above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants