fix(plugins-view): Register custom plugin registries from devfile plugins #1131

vinokurig · 2021-06-09T10:32:21Z

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Scan devfile plugins and if it has custom plugin registry source, add it's plugin registry to che-theia's plugin registry cache.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19898

How to test this PR?

Start a workspace from this devfile:

apiVersion: 1.0.0
metadata:
  name: wksp-uhias
components:
  - type: cheEditor
    reference: 'https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1131/che_theia_meta.yaml'
    alias: che-theia
  - id: editorconfig/editorconfig/0.14.4
    type: chePlugin
    registryUrl: 'http://vinokur-registry.surge.sh/path/to/registry/v3/'

Open the Plugins view View => Plugins.
Click the three dots button and select Show installed plugins.
See: the plugin editorconfig is shown in the list, the icon is displayed as well.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

…gins Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

che-bot · 2021-06-09T11:09:51Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-09T11:23:01Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-09T11:23:32Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-09T11:23:48Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

extensions/eclipse-che-theia-plugin-ext/src/browser/plugin/che-plugin-manager.ts

RomanNikitenko · 2021-06-10T06:21:21Z

I tested and can see installed plugin

I noticed a warning

I don't know what I should check in settings:

@vinokurig
is it related to your changes?

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

RomanNikitenko · 2021-06-10T08:49:48Z

It looks like I have the same behavior for the next version of the editor, so without your changes:

Do you know - is it a bug or I'm doing something wrong?
Should I create a separate issue for that problem?

RomanNikitenko · 2021-06-10T09:02:55Z

Created a separate issue eclipse-che/che#19955

che-bot · 2021-06-10T09:20:08Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-10T09:54:16Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-10T15:24:25Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

codecov · 2021-06-11T10:49:48Z

Codecov Report

Merging #1131 (da3183b) into master (eeb4526) will increase coverage by 2.95%.
The diff coverage is 54.31%.

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
+ Coverage   29.45%   32.40%   +2.95%     
==========================================
  Files         277      285       +8     
  Lines        9336     9683     +347     
  Branches     1380     1461      +81     
==========================================
+ Hits         2750     3138     +388     
+ Misses       6487     6447      -40     
+ Partials       99       98       -1

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <ø> (ø)`
...e-sync-tracker/src/browser/sync-process-tracker.ts	`0.00% <0.00%> (ø)`
...ovisioner/src/node/git-configuration-controller.ts	`0.00% <0.00%> (ø)`
...eia-plugin-remote/src/node/hosted-plugin-remote.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-host-custom.ts	`0.00% <0.00%> (ø)`
...in-remote/src/node/plugin-remote-backend-module.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-remote-init.ts	`0.00% <0.00%> (ø)`
...-che-theia-plugin-remote/src/node/plugin-remote.ts	`0.00% <0.00%> (ø)`
...ugin-remote/src/node/server-plugin-proxy-runner.ts	`0.00% <0.00%> (ø)`
...plugin-remote/src/node/terminal-container-aware.ts	`0.00% <0.00%> (ø)`
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1217e60...da3183b. Read the comment docs.

che-bot · 2021-06-11T12:05:16Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-11T13:00:13Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-11T14:39:57Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1131
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1131

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

…gins (#1131) Scan devfile plugins and if it has custom plugin registry source, add it's plugin registry to che-theia's plugin registry cache.

vinokurig changed the title ~~Register custom plugin registries from devfile plugins~~ fix (plugins view): Register custom plugin registries from devfile plugins Jun 9, 2021

vinokurig force-pushed the che-19898 branch 2 times, most recently from ab2cbff to 75c0ccb Compare June 9, 2021 10:35

fix(plugins-view): Register custom plugin registries from devfile plu…

8d71427

…gins Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig force-pushed the che-19898 branch from 75c0ccb to 8d71427 Compare June 9, 2021 10:37

vinokurig changed the title ~~fix (plugins view): Register custom plugin registries from devfile plugins~~ fix(plugins-view): Register custom plugin registries from devfile plugins Jun 9, 2021

vinokurig marked this pull request as ready for review June 9, 2021 12:01

vinokurig requested review from azatsarynnyy, benoitf, RomanNikitenko and vzhukovs as code owners June 9, 2021 12:01

vinokurig requested a review from vitaliy-guliy June 9, 2021 12:01

ericwill approved these changes Jun 9, 2021

View reviewed changes

RomanNikitenko reviewed Jun 10, 2021

View reviewed changes

extensions/eclipse-che-theia-plugin-ext/src/browser/plugin/che-plugin-manager.ts Outdated Show resolved Hide resolved

code cleanup

fde07c5

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig force-pushed the che-19898 branch from d8b02a6 to fde07c5 Compare June 10, 2021 08:39

RomanNikitenko approved these changes Jun 10, 2021

View reviewed changes

vitaliy-guliy approved these changes Jun 10, 2021

View reviewed changes

fix remove plugin function

5accd7f

Merge remote-tracking branch 'origin/master' into che-19898

6a39c59

fix formatting

da3183b

vinokurig force-pushed the che-19898 branch from b45efca to da3183b Compare June 11, 2021 13:36

vinokurig merged commit 7e03e0b into master Jun 11, 2021

vinokurig deleted the che-19898 branch June 11, 2021 14:43

che-bot added this to the 7.32 milestone Jun 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(plugins-view): Register custom plugin registries from devfile plugins #1131

fix(plugins-view): Register custom plugin registries from devfile plugins #1131

vinokurig commented Jun 9, 2021 •

edited

Loading

che-bot commented Jun 9, 2021

che-bot commented Jun 9, 2021

che-bot commented Jun 9, 2021

che-bot commented Jun 9, 2021

RomanNikitenko commented Jun 10, 2021 •

edited

Loading

RomanNikitenko commented Jun 10, 2021

RomanNikitenko commented Jun 10, 2021

che-bot commented Jun 10, 2021

che-bot commented Jun 10, 2021

che-bot commented Jun 10, 2021

codecov bot commented Jun 11, 2021 •

edited

Loading

che-bot commented Jun 11, 2021

che-bot commented Jun 11, 2021

che-bot commented Jun 11, 2021

fix(plugins-view): Register custom plugin registries from devfile plugins #1131

fix(plugins-view): Register custom plugin registries from devfile plugins #1131

Conversation

vinokurig commented Jun 9, 2021 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

che-bot commented Jun 9, 2021

che-bot commented Jun 9, 2021

che-bot commented Jun 9, 2021

che-bot commented Jun 9, 2021

RomanNikitenko commented Jun 10, 2021 • edited Loading

RomanNikitenko commented Jun 10, 2021

RomanNikitenko commented Jun 10, 2021

che-bot commented Jun 10, 2021

che-bot commented Jun 10, 2021

che-bot commented Jun 10, 2021

codecov bot commented Jun 11, 2021 • edited Loading

Codecov Report

che-bot commented Jun 11, 2021

che-bot commented Jun 11, 2021

che-bot commented Jun 11, 2021

vinokurig commented Jun 9, 2021 •

edited

Loading

RomanNikitenko commented Jun 10, 2021 •

edited

Loading

codecov bot commented Jun 11, 2021 •

edited

Loading