Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Che Dashboard to use Yarn 1 (support for Big Endian systems like s390x) #20138

Closed
Tracked by #20068
nickboldt opened this issue Jul 15, 2021 · 4 comments · Fixed by eclipse-che/che-dashboard#306
Assignees
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Jul 15, 2021

Is your enhancement related to a problem? Please describe.

Today the Che Dashboard uses Yarn2 in Che and is converted to using Yarn1 in CRW, because Yarn 2 doesn't support Big Endian arches like s390x.

Describe the solution you'd like

Rather than using one BE-incompatible system in Che and a BE-compatible one in CRW, we could simply use Yarn 1 in both places, which would allow us to build the Che Dashboard for Z as well as the CRW one. This would allow us to potentially catch Z related bugs sooner.

Describe alternatives you've considered

Continue to use Yarn2 in Che and Yarn1 in CRW, and maintain scripts/Dockerfile transformation that convert from one to the other, along with all the requisite bug fixes...

https://github.com/redhat-developer/codeready-workspaces-images/commits/crw-2-rhel-8/codeready-workspaces-dashboard/build

Additional context

We intend to be able to build and release all the Che projects for at least 3 (or 4) arches:

  • amd64 / x86_64
  • s390x (Linux on Z)
  • ppc64le (Power)
  • aarch64 / arm64

So this will eventually block that endeavour unless a version of Yarn 2 appears that supports Big Endian.

@nickboldt nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 15, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 15, 2021
@nickboldt nickboldt added area/ci CI build and releases, PR testing, & whitelabel/productization issues area/dashboard severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 15, 2021
@sleshchenko sleshchenko added this to the 7.34 milestone Jul 23, 2021
@aditijadhav38
Copy link
Contributor

@nickboldt Even Che-plugin-registry was also moved to yarn 2. So could you please let me know if there are any plans for moving back to yarn1 for plugin-registry.

@nickboldt
Copy link
Contributor Author

There are no plans to move to Yarn 1 in plugin registry. However @benoitf has suggested that for Travis + s390x builds of plugin reg, to bypass Yarn 2 BigEndian issues, we could:

rm -rf .pnp.js .yarn .yarnrc.yml

(or something like that)

@benoitf
Copy link
Contributor

benoitf commented Aug 12, 2021

it should be also possible to set

yarn set version classic

before running yarn commands

@aditijadhav38
Copy link
Contributor

@nickboldt @benoitf Thanks it worked.. Able to build plugin-registry image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues area/dashboard kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants