Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main DevWorkspace Endpoint is considered as ready/available while it's not #20481

Closed
Tracked by #20444 ...
benoitf opened this issue Sep 17, 2021 · 2 comments
Closed
Tracked by #20444 ...
Assignees
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next

Comments

@benoitf
Copy link
Contributor

benoitf commented Sep 17, 2021

Describe the bug

Dashboard redirect to the IDE page when the editor is ready
DevWorkspace operator flags the editor being as ready when the main endpoint is ready.

But it turns out that as now the endpoint are secured, DevWorkspace will check the main URL endpoint and it'll return for example on openshift a OAuth page. (so the answer is HTTP/200)

While the endpoint may not be listening or ready, DW is flagged as ready due to that oAuth page

so at the end, dashboard think the DevWorkspace is ready, redirects to the main URL and we get a 502/bad gateway error as the underlying component may not be ready.

Che version

next (development version)

Steps to reproduce

Deploy a workspace on openshift (to make it really reproducible, the editor listening port should never be started)

Expected behavior

DevWorkspace is flagged ready only when main endpoint is really reachable (not the oAuth page)

Runtime

OpenShift

Screenshots

Screenshot 2021-09-17 at 11 35 42

Installation method

chectl/next

Environment

other (please specify in additional context)

Eclipse Che Logs

No response

Additional context

No response

@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Sep 17, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 17, 2021
@amisevsk amisevsk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 17, 2021
@amisevsk
Copy link
Contributor

Related: devfile/api#168

@sparkoo
Copy link
Member

sparkoo commented Oct 11, 2021

fixed by eclipse-che/che-operator#1119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next
Projects
None yet
Development

No branches or pull requests

5 participants