feat: accessible workspace healthz endpoint #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkoo
requested review from
AndrienkoAleksandr,
flacatus,
mmorhun,
nickboldt and
tolusha
as code owners
sparkoo
requested review from
metlos,
mshaposhnik,
sleshchenko,
skabashnyuk and
xbaran4
|
/retest |
sleshchenko
reviewed
Oct 4, 2021
|
/retest |
tolusha
approved these changes
Oct 5, 2021
metlos
reviewed
Oct 5, 2021
sparkoo
force-pushed
the
gh20481-workspaceHealthzEndpoint
branch
from
3b3b7ef to
0aa3229
Compare
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
Signed-off-by: Michal Vala <mvala@redhat.com>
sparkoo
force-pushed
the
gh20481-workspaceHealthzEndpoint
branch
from
ae668c2 to
6b747bf
Compare
|
reminder: if this is a blocker for 2.12 (https://issues.redhat.com/browse/CRW-2360), need this in the 7.36.x branch. |
# Conflicts: # controllers/devworkspace/solver/che_routing.go # controllers/devworkspace/solver/che_routing_test.go
|
/retest |
metlos
approved these changes
Oct 11, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: metlos, sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
/healthzpath of main workspace endpoint accessible from the outside. DevWorkspace Operator needs this to check whether workspace is alive.TODO:
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20481
How to test this PR?
latest image here -->
quay.io/mvala/che-operator:gh20481-workspaceHealthzEndpointkubectl get dw -n <user-namespace>/healthzand try to curl it. You should get 404 response. That is ok, because Theia does not actually implement that endpoint. In case this PR is not working, you would be redirected to openshift login page.<main-url>/healthzmust be accessible.chectl server:deploy \ --installer operator \ --platform openshift \ --che-operator-image quay.io/mvala/che-operator:gh20481-workspaceHealthzEndpoint \ --workspace-engine=dev-workspacePR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.