Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that CHE_INTEGRATION_XXXX_SERVER__ENDPOINTS and CHE_INTEGRATION_XXXX_OAUTH__ENDPOINT properties are properly set. #20902

Closed
skabashnyuk opened this issue Dec 8, 2021 · 1 comment
Closed

Ensure that CHE_INTEGRATION_XXXX_SERVER__ENDPOINTS and CHE_INTEGRATION_XXXX_OAUTH__ENDPOINT properties are properly set. #20902

skabashnyuk opened this issue Dec 8, 2021 · 1 comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.41

Comments

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Dec 8, 2021 •
edited
Loading

Is your task related to a problem? Please describe

Ensure that CHE_INTEGRATION_XXXX_SERVER__ENDPOINTS CHE_INTEGRATION_XXXX_OAUTH__ENDPOINT properties are properly set.

Describe the solution you'd like

For Gitlab, Github, Bitbucket we need to ensure that che-operator is able to.

  1. CHE_INTEGRATION_XXXX_SERVER__ENDPOINTS from customProperties appended with che.eclipse.org/scm-server-endpoint from all *-oauth-config secrets
  2. CHE_INTEGRATION_XXXX_OAUTH__ENDPOINT is set from che.eclipse.org/scm-server-endpoint from all *-oauth-config secrets

Describe alternatives you've considered

No response

Additional context

#20496
https://www.eclipse.org/che/docs/che-7/administration-guide/configuring-authorization/#configuring_gitlab_servers_che
@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Dec 8, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 8, 2021
@skabashnyuk skabashnyuk changed the title Ensure that CHE_INTEGRATION_XXXX_SERVER__ENDPOINTS CHE_INTEGRATION_XXXX_OAUTH__ENDPOINT properties are properly set. Ensure that CHE_INTEGRATION_XXXX_SERVER__ENDPOINTS and CHE_INTEGRATION_XXXX_OAUTH__ENDPOINT properties are properly set. Dec 8, 2021
@xbaran4
Copy link
Contributor

xbaran4 commented Dec 8, 2021

To be more consistent with github config (CHE_OAUTH2_GITHUB...), I would propose to also change:
CHE_OAUTH_GITLAB_CLIENTID__FILEPATH --> CHE_OAUTH2_GITLAB_CLIENTID__FILEPATH
CHE_OAUTH_GITLAB_CLIENTSECRET__FILEPATH --> CHE_OAUTH2_GITLAB_CLIENTSECRET__FILEPATH

@mmorhun mmorhun added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 8, 2021
@skabashnyuk skabashnyuk mentioned this issue Dec 8, 2021
Closed
41 tasks
This was referenced Dec 13, 2021
Merged
Closed
@tolusha tolusha closed this as completed Dec 16, 2021
@tolusha tolusha added this to the 7.41 milestone Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.41
Development

No branches or pull requests
5 participants
@skabashnyuk @tolusha @mmorhun @che-bot @xbaran4