Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite user's email if it is set in the database #20922

Closed
Tracked by #20874
tolusha opened this issue Dec 13, 2021 · 0 comments · Fixed by eclipse-che/che-server#198
Closed
Tracked by #20874

Don't overwrite user's email if it is set in the database #20922

tolusha opened this issue Dec 13, 2021 · 0 comments · Fixed by eclipse-che/che-server#198
Labels
area/che-server engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.

Comments

@tolusha
Copy link
Contributor

tolusha commented Dec 13, 2021 •
edited
Loading

Is your task related to a problem? Please describe

There is the migration guide to DevWorkspace engine [1]. It turned out that InitializationFilter [2] overwrite user's email.

Describe the solution you'd like

Use email from the database if exists.

Describe alternatives you've considered

No response

Additional context

[1] eclipse-che/che-docs#2159
[2] https://github.com/eclipse-che/che-server/blob/main/infrastructures/openshift/src/main/java/org/eclipse/che/workspace/infrastructure/openshift/multiuser/oauth/OpenshiftTokenInitializationFilter.java#L104-L108
@tolusha tolusha added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Dec 13, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 13, 2021
@tolusha tolusha mentioned this issue Dec 13, 2021
Closed
6 tasks
@svor svor added area/che-server engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 13, 2021
This was referenced Dec 14, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-server engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Do not override existed user's email with dummy on OpenShift skabashnyuk/che-server
3 participants
@svor @tolusha @che-bot