fix: Do not override existed user's email with dummy on OpenShift #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
requested review from
amisevsk,
metlos,
nickboldt and
sleshchenko
as code owners
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
mshaposhnik
approved these changes
Dec 14, 2021
tolusha
approved these changes
Dec 15, 2021
sparkoo
reviewed
Dec 15, 2021
...e/workspace/infrastructure/openshift/multiuser/oauth/OpenshiftTokenInitializationFilter.java
Outdated
Show resolved
Hide resolved
wsmaster/che-core-api-user/src/main/java/org/eclipse/che/api/user/server/UserManager.java
Outdated
Show resolved
Hide resolved
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
sparkoo
approved these changes
Dec 15, 2021
|
❌ E2E Happy path tests failed ❗ See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
|
[crw-ci-test --rebuild] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix: Do not override existed user's email with dummy on OpenShift
Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
Fixes eclipse-che/che#20922
How to test this PR?
/api/user. Original email have to stay the same.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.