Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub OAuth flow is going into infinite loop if wrong configuration #21077

Closed
vinokurig opened this issue Jan 26, 2022 · 4 comments · Fixed by eclipse-che/che-dashboard#452
Closed

GitHub OAuth flow is going into infinite loop if wrong configuration #21077

vinokurig opened this issue Jan 26, 2022 · 4 comments · Fixed by eclipse-che/che-dashboard#452
Assignees
@akurinnoy
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Jan 26, 2022 •
edited
Loading

Describe the bug

After setup the GitHub oAuth provider and using a factory with private repo browser goes into a refresh loop.

Che version

next (development version)

Steps to reproduce

  1. Configure GitHub oAuth
  2. Create factory wit a private repo url.
  3. See: browser goes to cyclic refresh:
screencast-nimbus-capture-2022.01.26-17_13_02.mp4

Expected behavior

Workspace should start.

Runtime

minikube

Screenshots

No response

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

No response
@vinokurig vinokurig added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 26, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 26, 2022
@vinokurig vinokurig mentioned this issue Jan 26, 2022
Closed
@l0rd l0rd added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. area/dashboard and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 26, 2022
@l0rd
Copy link
Contributor

l0rd commented Jan 26, 2022

@ibuziuk @olexii4 @akurinnoy I am setting that as a blocker as it looks like it's not possible to use Che with private repositories anymore.

@l0rd l0rd changed the title GitHub oAuth flow is brocken GitHub OAuth flow is broken Jan 26, 2022
@ibuziuk
Copy link
Member

ibuziuk commented Jan 27, 2022

Thanks for reporting. @vinokurig is it reproducible against the dogfooding instance for you, since I was not able to repro?
@olexii4 @akurinnoy could you please take a look?

@akurinnoy akurinnoy self-assigned this Jan 27, 2022
@vinokurig
Copy link
Contributor Author

Closing as it was a problem on my side. Wrong copy paste :)

@benoitf
Copy link
Contributor

benoitf commented Jan 28, 2022

I think that even if oAuth is not configured properly Dashboard should display an error and not goes into an infinite loop

@benoitf benoitf reopened this Jan 28, 2022
@benoitf benoitf changed the title GitHub OAuth flow is broken GitHub OAuth flow is going into infinite loop if wrong configuration Jan 28, 2022
@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. and removed severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. labels Jan 28, 2022
@ibuziuk ibuziuk mentioned this issue Feb 1, 2022
Closed
35 tasks
@akurinnoy akurinnoy mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent infinite reloads loop eclipse-che/che-dashboard
6 participants
@benoitf @l0rd @ibuziuk @vinokurig @akurinnoy @che-bot