Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy and start editors in one of the Devfile containers #21354

Closed
l0rd opened this issue Apr 27, 2022 · 1 comment
Closed

Copy and start editors in one of the Devfile containers #21354

l0rd opened this issue Apr 27, 2022 · 1 comment
Labels
area/devworkspace-operator area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Apr 27, 2022

Is your enhancement related to a problem? Please describe

There are 2 different ways to run editors today: as Theia in its own sidecar contaienr or as VS Code that is hosted in one of the Devfile container. As a result Theia and VS Code behaviors are not consistent and are harder to maintain.

VS Code cannot run in its isolated container as its extensions need to run where the dev tools are and cannot run in a remote container.

image

Describe the solution you'd like

Rather than running their own sidecar, IDEs should be copied in a volume by an initcontainer and executed in one of the containers defined in the Devfile.

  • Theia should be adapted to this new behavior (VS Code and JetBrains IDEs are already adapted)
  • If there are no container in a Devfile the editor should be executed in the default DevComponent
  • If there are more than one container in a Devfile the editor should be executed in the container with attribute controller.devfile.io/component-role: plugin-host if it exist, otherwise in the first container that has mountSources: true.

Additional context

This is a subtask of #21340

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 27, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 27, 2022
@l0rd l0rd added area/devworkspace-operator area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 27, 2022
@l0rd l0rd mentioned this issue Jun 8, 2022
64 tasks
@l0rd
Copy link
Contributor Author

l0rd commented Jun 8, 2022

This has been done for JetBrains IDEs as part of #20863. We are not going to do it for Che-Theia, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devworkspace-operator area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

2 participants