Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provides OpenVSX CheCluster URL to user containers #21600

Closed
Tracked by #20549
benoitf opened this issue Aug 1, 2022 · 1 comment · Fixed by eclipse-che/che-dashboard#609
Closed
Tracked by #20549

Provides OpenVSX CheCluster URL to user containers #21600

benoitf opened this issue Aug 1, 2022 · 1 comment · Fixed by eclipse-che/che-dashboard#609
Assignees
@olexii4
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@benoitf
Copy link
Contributor

benoitf commented Aug 1, 2022 •
edited
Loading

Is your task related to a problem? Please describe

Part of #20549
Plugin-Registry will include an OpenVSX instance.
Admin will have a choice to say to either use 'OpenVSX.org' or 'plugin-registry OpenVSX' with the CheCluster #21598

And then, CheCode(our VS Code) needs to know when booting if registry needs to be OpenVSX.org or another URL
che-incubator/che-code#85

But to know what to do, CheCode needs to get the value specified in the CheCluster CR but a user container has no access to the CheCluster object, so it's the Dashboard that needs to propagate this information

Describe the solution you'd like

depends on #21598
Adds OPENVSX_URL with value coming from components.devWorkspace.cheServer.pluginRegistry.OpenVSXURL

Describe alternatives you've considered

No response

Additional context

No response
@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. area/dashboard labels Aug 1, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 1, 2022
This was referenced Aug 1, 2022
Closed
Closed
@ibuziuk ibuziuk added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 2, 2022
@l0rd
Copy link
Contributor

l0rd commented Aug 2, 2022

I would use OPENVSX_REGISTRY_URL as the name of the env variable. Added the comment to the CheCluster issue too.

@tolusha tolusha removed the area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator label Aug 6, 2022
@ibuziuk ibuziuk mentioned this issue Aug 8, 2022
Closed
67 tasks
@olexii4 olexii4 self-assigned this Aug 16, 2022
@olexii4 olexii4 mentioned this issue Aug 23, 2022
Merged
@olexii4 olexii4 closed this as completed Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olexii4 olexii4

Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provides OpenVSX CheCluster URL to user containers eclipse-che/che-dashboard
6 participants
@benoitf @l0rd @ibuziuk @tolusha @olexii4 @che-bot