Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides OpenVSX CheCluster URL to user containers #609

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Provides OpenVSX CheCluster URL to user containers #609

merged 4 commits into from
Aug 23, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 19, 2022

What does this PR do?

Provides OpenVSX CheCluster URL to user containers

What issues does this PR fix or reference?

fixes eclipse-che/che#21600

Is it tested? How?

Знімок екрана 2022-08-23 о 17 09 09

@che-bot
Copy link
Contributor

che-bot commented Aug 19, 2022

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2022

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2022

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Aug 20, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-609

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-609

@openshift-ci
Copy link

openshift-ci bot commented Aug 20, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path 86d3b60 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2022
@olexii4 olexii4 requested a review from ibuziuk August 22, 2022 14:05
@benoitf
Copy link
Contributor

benoitf commented Aug 23, 2022

Hi, will it be merged soon ?

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 23, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

New changes are detected. LGTM label has been removed.

@che-bot
Copy link
Contributor

che-bot commented Aug 23, 2022

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 merged commit 1f2de3b into main Aug 23, 2022
@olexii4 olexii4 deleted the CHE-21600 branch August 23, 2022 14:22
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-609

@che-bot che-bot added this to the 7.53 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provides OpenVSX CheCluster URL to user containers
6 participants