Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer RELATED_IMAGE_gateway_authentication_sidecar and RELATED_IMAGE_gateway_authorization_sidecar images in CSV? #21617

Closed
Tracked by #21615 ...
nickboldt opened this issue Aug 6, 2022 · 2 comments
Assignees
Labels
area/install Issues related to installation, including offline/air gap and initial setup kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Milestone

Comments

@nickboldt
Copy link
Contributor

Is your task related to a problem? Please describe

I noticed today that in Che-operator main branch, we still use:

- name: RELATED_IMAGE_gateway_authentication_sidecar
  value: quay.io/openshift/origin-oauth-proxy:4.7
- name: RELATED_IMAGE_gateway_authorization_sidecar
  value: quay.io/openshift/origin-kube-rbac-proxy:4.7

-- ./config/manager/manager.yaml
-- ./bundle/next/eclipse-che-preview-openshift/manifests/che-operator.clusterserviceversion.yaml
-- ./deploy/deployment/openshift/combined.yaml
-- ./deploy/deployment/openshift/objects/che-operator.Deployment.yaml
(plus the helmcharts and k8s files too)

While downstream we have:

- name: RELATED_IMAGE_gateway_authentication_sidecar
  value: registry.redhat.io/openshift4/ose-oauth-proxy:v4.8
- name: RELATED_IMAGE_gateway_authorization_sidecar
  value: registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.8

-- ./manifests/devspaces.csv.yaml

Describe the solution you'd like

Given that Openshift v4.10 is out, and it's a prereq for using Dev Spaces, and that Openshift v4.11 is out soon, should we update to v4.11 when it's live?

Describe alternatives you've considered

Or is there some reason we're still on 4.7/4.8?

Additional context

No response

@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Aug 6, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 6, 2022
@tolusha tolusha mentioned this issue Aug 6, 2022
67 tasks
@tolusha
Copy link
Contributor

tolusha commented Aug 8, 2022

I don't think we can use registry.redhat.io/openshift4 registry in upstream.
But we can switch to 4.8 or even 4.9 in quay.io/openshift

@amisevsk @sparkoo
Do you think it is safe enough to switch to a higher version? Any specific tests?

@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach area/install Issues related to installation, including offline/air gap and initial setup and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 8, 2022
@tolusha
Copy link
Contributor

tolusha commented Aug 10, 2022

So, we have to do:

  1. Update [1] to [2] & [3]
  2. Launch make update-dev-resources to propagate these changes to all related resources including olm bundle
  3. Spin up OpenShift cluster and launch make run to deploy Eclipse Che
  4. Test if use can log in and create workspace

[1] https://github.com/eclipse-che/che-operator/blob/152c8211a673348ebc60aa260e2fb6eecaeff81b/config/manager/manager.yaml#L84-L87
[2] https://quay.io/repository/openshift/origin-oauth-proxy?tab=tags&tag=4.9
[3] https://quay.io/repository/openshift/origin-kube-rbac-proxy?tab=tags&tag=4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to installation, including offline/air gap and initial setup kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

4 participants