Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify installation on an OCP 4.12 instance without the Console #21642

Closed
Tracked by #21653
l0rd opened this issue Aug 19, 2022 · 2 comments
Closed
Tracked by #21653

Verify installation on an OCP 4.12 instance without the Console #21642

l0rd opened this issue Aug 19, 2022 · 2 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone
7.54

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 19, 2022 •
edited
Loading

Is your task related to a problem? Please describe

With 4.12 OpenShift console will be an optional component (part of the composable OpenShift effort / CONSOLE-3160). When it’s not installed, console CRDs like ConsoleLink, ConsoleCLIDownload, ConsoleYAMLSample, and ConsoleQuickStart won’t be available on the cluster.

Describe the solution you'd like

Make sure operators don’t fail when the CRD is missing.
@l0rd l0rd added kind/task Internal things, technical debt, and to-do tasks to be performed. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 19, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 19, 2022
@l0rd l0rd changed the title Verify Eclipse Che on an OCP 4.12 instance without the Console Verify installation on an OCP 4.12 instance without the Console Aug 19, 2022
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 19, 2022
@tolusha
Copy link
Contributor

tolusha commented Aug 19, 2022

Should not have any problems because we already have this check
https://github.com/eclipse-che/che-operator/blob/71a5ba500c59199c28e29e6845bdf7cfe9c7df93/pkg/deploy/consolelink/consolelink.go#L49

@l0rd
Copy link
Contributor Author

l0rd commented Aug 19, 2022

@tolusha great. If you believe that's not worth testing let's close this issue then.

@tolusha tolusha mentioned this issue Aug 25, 2022
Closed
82 tasks
@tolusha tolusha mentioned this issue Sep 7, 2022
Merged
11 tasks
@tolusha tolusha closed this as completed Sep 7, 2022
@tolusha tolusha added this to the 7.54 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
7.54
Development

No branches or pull requests
3 participants
@l0rd @tolusha @che-bot