Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing recommended extensions to .vscode/extensions.json in all che-samples #21644

Closed
vitaliy-guliy opened this issue Aug 19, 2022 · 2 comments
Assignees
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Aug 19, 2022

Is your enhancement related to a problem? Please describe

I noticed, that not all the plugins appeared to be installed after creating a workspace from quarkus sample.

.vscode/extensions.json for quarkus sample contains only one redhat.vscode-quarkus recommendation.
Che-Theia performs the plugin installation properly. It opens redhat/vscode-quarkus/latest/che-theia-plugin.yaml, downloads all the extensions from extensions: block and does the same for all the dependencies from dependencies:.

When che-code handles .vscode/extensions.json file, it does not aware about redhat/vscode-quarkus/latest/che-theia-plugin.yaml and does not install dependencies, that are described in dependencies: block

dependencies:
  - redhat/java
  - redhat/vscode-microprofile
  - vscjava/vscode-java-debug
  - vscjava/vscode-java-test

This is what I have after installing the recommendations for quarkus

Screenshot from 2022-08-19 17-35-42

Che-code does not touch redhat/vscode-quarkus/latest/che-theia-plugin.yaml, but installs all the dependencies, that are described in package.json of quarkus plugin.

  "extensionDependencies": [
    "redhat.vscode-microprofile",
    "redhat.java",
    "vscjava.vscode-java-debug",
    "vscode.html-language-features"
  ],

Describe the solution you'd like

Review all che-samples, that we use for workspace creation, and add missing extensions to .vscode/extensions.json

Describe alternatives you've considered

No response

Additional context

No response

@vitaliy-guliy vitaliy-guliy added kind/enhancement A feature request - must adhere to the feature request template. team/plugins severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 19, 2022
@svor svor added area/devfile-registry severity/P1 Has a major impact to usage or development of the system. sprint/next and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 19, 2022
This was referenced Aug 22, 2022
@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Aug 30, 2022

Pull Requests to merge:

@svor
Copy link
Contributor

svor commented Sep 1, 2022

downstream issue: https://issues.redhat.com/browse/CRW-3302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants