You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
… options to LS (eclipse-che#2735)
* Fixeseclipse-che#2728: Respect user settings when sending formatting options to LS
Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
* Remove spaces in empty line
Formatting options passed to language servers are hardcoded to:
insertSpaces = true
tabWidth = 3
(why 3 ?!)The
insertSpaces = true
value comes from here: https://github.com/eclipse/che/blob/master/plugins/plugin-languageserver/che-plugin-languageserver-ide/src/main/java/org/eclipse/che/plugin/languageserver/ide/editor/LanguageServerFormatter.java#L179The
tabWidth = 3
value seems to come from here: https://github.com/eclipse/che/blob/master/ide/che-core-ide-api/src/main/java/org/eclipse/che/ide/api/editor/editorconfig/DefaultTextEditorConfiguration.java#L35Reproduction Steps:
Expected behavior:
The document is formatted according to the current user preferences.
Observed behavior:
The document is formatted with a hardcoded settings. The user preferences are not applied.
Che version: latest master
OS and version: Fedora 24
Docker version: 1.10.3
Che install: local build
Additional information:
The text was updated successfully, but these errors were encountered: