Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Server Protocol : Code Action #3957

Closed
gorkem opened this issue Jan 31, 2017 · 2 comments
Closed

Language Server Protocol : Code Action #3957

gorkem opened this issue Jan 31, 2017 · 2 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@gorkem
Copy link
Contributor

gorkem commented Jan 31, 2017

The codeaction request is sent from the client to the server to compute code actions for a given text document and Diagnosis. This should be part of #2109

See also:
https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#textDocument_codeAction

@ghost ghost added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 10, 2017
@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 6, 2017

Working on this.
My approach is to look for an action that has the same id as the "command" field of the code action. The extra parameters will be passed to the action in an extended subclass of ActionEvent.

For the purposes of this issue, I'd like to implement a "lsp.applyTextEdit" action that applies a list of lsp TextEdit objects to the current editor.
In second step, it would make sense to implement "lsp.applyWorkspaceEdit" to implement changes to more than just one file. However, I would do that in a separate PR.

@benoitf
Copy link
Contributor

benoitf commented Jun 28, 2017

Fixed by #4345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants