Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnnotationModelImpl.getAnnotationIterator(int, int, boolean, boolean) never returns anything #4338

Closed
tsmaeder opened this issue Mar 7, 2017 · 0 comments
Closed

AnnotationModelImpl.getAnnotationIterator(int, int, boolean, boolean) never returns anything #4338

tsmaeder opened this issue Mar 7, 2017 · 0 comments
Assignees
@evidolob
Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Mar 7, 2017

While working on #3957 , I've noticed that using an AnnotationQueryEvent with a range never returned any annotations.
I traced this to the usage of the DocumentPositionMap in AnnotationModelImpl. When annotations are added to the annotation model, their positions are never added to the documentPositionMap. So when the iterator tries use the positions from that map, it's always empty.

Version: master as of March 7, 2017.
@ghost ghost added the kind/question Questions that haven't been identified as being feature requests or bugs. label Mar 7, 2017
@vparfonov vparfonov added kind/bug Outline of a bug - must adhere to the bug report template. sprint/next team/ide and removed kind/question Questions that haven't been identified as being feature requests or bugs. labels Mar 14, 2017
@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 17, 2017
evidolob pushed a commit that referenced this issue Mar 21, 2017
#4338 implement correctly 'AnnotationModelImpl.getAnnotationIterator(…
70b1c15 
…int, int, boolean, boolean)'

Signed-off-by: Even Vidolob <evidolob@codenvy.com>
@evidolob evidolob mentioned this issue Mar 21, 2017
Merged
evidolob pushed a commit that referenced this issue Mar 21, 2017
#4338 remove checked exception
2e2a5a8 
Signed-off-by: Even Vidolob <evidolob@codenvy.com>
@evidolob evidolob added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 21, 2017
evidolob pushed a commit that referenced this issue Mar 22, 2017
#4338 implement correctly 'AnnotationModelImpl.getAnnotationIterator' (…
1b0b71f 
…#4489)

* #4338 implement correctly 'AnnotationModelImpl.getAnnotationIterator(int, int, boolean, boolean)'

Signed-off-by: Even Vidolob <evidolob@codenvy.com>
JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017
eclipse-che#4338 implement correctly 'AnnotationModelImpl.getAnnotati…
bc38f67 
…onIterator' (eclipse-che#4489)

* eclipse-che#4338 implement correctly 'AnnotationModelImpl.getAnnotationIterator(int, int, boolean, boolean)'

Signed-off-by: Even Vidolob <evidolob@codenvy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evidolob @vparfonov @tsmaeder