Remove usage of the Machine API in the Chedir

[mshaposhnik]

Remove usage of the Machine API in Chedir. Example: here and replace with exec's.

[benoitf]

I don't see why it's a blocker as I was not informed that it's gonna be removed and that when the code has been changed to use agent, job was not done on all parts ?

[skabashnyuk]

Sorry we thought that we know all places where it's used. now we know what cheConf/ che dir is used it too. severity/blocker set to inform about our intent to remove Deprecated Machine API asap.

[benoitf]

why the job of migrating machine api to agent was not including chedir ?

[skabashnyuk]

We don't know how it works and want to delegate it to authors who knows how it works.

[skabashnyuk]

PR where we introduced exec #2163

Available API:

• REST API
• Websocket API
• Events

@benoitf Do you know where Chedir functionality is located?

[benoitf]

@skabashnyuk sorry I didn't see your question
https://github.com/eclipse/che/blob/master/dockerfiles/lib/src/internal/dir/che-dir.ts

[skabashnyuk]

I see that /api/workspace is used in three places in https://github.com/eclipse/che/blob/master/dockerfiles/lib/src/internal/dir/che-dir.ts

• checkCheIsNotRunning
• checkCheIsRunning
• pingCheAction

@benoitf Am I correct ?

[benoitf]

@skabashnyuk there are other places
I think you are interested in calls to machine API which are only there:
https://github.com/eclipse/che/blob/master/dockerfiles/lib/src/api/wsmaster/machine/machine-service-client.ts