Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Composer plugin to avoid using Everrest based Websocket calls #5348

Closed
azatsarynnyy opened this issue Jun 12, 2017 · 7 comments
Closed

Rework Composer plugin to avoid using Everrest based Websocket calls #5348

azatsarynnyy opened this issue Jun 12, 2017 · 7 comments
Assignees
@dkulieshov
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Jun 12, 2017 •
edited
Loading

ComposerOutputHandler uses WsAgentStateController#getMessageBus for listening an output. Need to replace it with JSON-RPC.
@azatsarynnyy azatsarynnyy added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Jun 12, 2017
@azatsarynnyy azatsarynnyy changed the title Rework Composer plugin to replace everrest based Websocket calls with new JSON-RPC framework Rework Composer plugin to replace Everrest based Websocket calls with new JSON-RPC framework Jun 12, 2017
@azatsarynnyy azatsarynnyy changed the title Rework Composer plugin to replace Everrest based Websocket calls with new JSON-RPC framework Rework Composer plugin to avoid using Everrest based Websocket calls Jun 12, 2017
@gazarenkov gazarenkov mentioned this issue Jun 12, 2017
Closed
6 tasks
@gazarenkov
Copy link
Contributor

@kaloyan-raev could you look at it?
that is a part of a movement to replace our "old styled" WS calls with JSON-RPC

@kaloyan-raev
Copy link
Contributor

@gazarenkov I am not sure what exactly I should do here. The ComposerOutputHandler is designed after the MavenMessageHandler. So when a PR for #5350 is created, I can do a similar one for Composer.

@gazarenkov
Copy link
Contributor

Just to make sure you aware, nothing urgent
and @dkuleshov can help you if needed
thanks

@dkulieshov dkulieshov self-assigned this Jun 23, 2017
@dkulieshov dkulieshov added the status/in-progress This issue has been taken by an engineer and is under active development. label Jun 23, 2017
@dkulieshov dkulieshov removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 5, 2017
@svor
Copy link
Contributor

svor commented Jul 5, 2017

@kaloyan-raev You can see how it is in PR #5527.
Especially pay attention to:
ArchetypeGenerator.java, MavenArchetypeJsonRpcMessenger.java and MavenMessagesHandler.java
Feel free to ask me if something is not clear.

@kaloyan-raev
Copy link
Contributor

@svor Thank you for the pointers. I will work on this on Friday.

kaloyan-raev added a commit that referenced this issue Jul 13, 2017
@kaloyan-raev
Rework Composer plugin to avoid using Everrest based Websocket calls
7ff1175 
Fixes #5348
kaloyan-raev added a commit that referenced this issue Jul 13, 2017
@kaloyan-raev
Rework Composer plugin to avoid using Everrest based Websocket calls
403d30d 
Fixes #5348

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@kaloyan-raev kaloyan-raev mentioned this issue Jul 13, 2017
Merged
@kaloyan-raev
Copy link
Contributor

@svor I created PR #5629

@svor
Copy link
Contributor

svor commented Jul 13, 2017

@kaloyan-raev I've reviewed, good job 👍

JPinkney pushed a commit to JPinkney/che that referenced this issue Aug 17, 2017
@kaloyan-raev @vparfonov
Rework Composer plugin to avoid using Everrest based Websocket calls (e…
a314315 
…clipse-che#5629)

* Rework Composer plugin to avoid using Everrest based Websocket calls

Fixes eclipse-che#5348

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>

* Fix dependencies

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkulieshov dkulieshov

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kaloyan-raev @gazarenkov @svor @dkulieshov @azatsarynnyy