Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Docker infrastructure implementation code to find what should be fixed or implemented #5423

Closed
garagatyi opened this issue Jun 21, 2017 · 3 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Docker infrastructure implementation has a lot of things implemented to get POC.
We should revise it to find out whether there is anything that should be reimplemented or fixed and might influence SPI design.

@garagatyi garagatyi added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jun 21, 2017
@garagatyi garagatyi changed the title Revise Docker infrastructure implementation code to find what should be fixed or implemeted Revise Docker infrastructure implementation code to find what should be fixed or implemented Jun 21, 2017
@skabashnyuk
Copy link
Contributor

Make sure these deprecated modules are reviewed

  • che-core-api-machine-shared
  • che-core-api-model-machine

@akorneta akorneta self-assigned this Jul 4, 2017
@akorneta akorneta added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 4, 2017
@akorneta
Copy link
Contributor

akorneta commented Jul 10, 2017

After the revision following issues were found:

  • Workspace infrastructure termination issue;
  • Machine config validation(circular dependencies) issue;
  • Cleanup + define how to deal with exceptions inside WorkspaceRuntimes;
  • Repair ssh access to the machine;
  • Define output format rel;
  • Rework snapshotting feature in accordance to master(workspace attributes + che properties).
  • Rewrite WorkspaceLinksInjector in accordance to clients needs issue;
  • Provide cleanup mechanism for docker infra isse;
  • Provide workspace start interruption feature(in compliance with master branch);
  • Write tests for infrastructure-docker module issue;
  • Rewrite workspace API module tests;
  • Get rid of RecipeDownloader + RecipeRetriever;

Cleanup commits:

8e1fe4b, 566a3df, 59aa09a, fd39d18, 1519136

@akorneta
Copy link
Contributor

removed modules:

  • che-core-api-machine-shared
  • che-core-api-model-machine

@akorneta akorneta removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants