Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Termination of workspace infrastructure #5570

Closed
akorneta opened this issue Jul 10, 2017 · 0 comments
Closed

Termination of workspace infrastructure #5570

akorneta opened this issue Jul 10, 2017 · 0 comments
Assignees
@voievodin @akorneta
Labels
target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@akorneta
Copy link
Contributor

akorneta commented Jul 10, 2017 •
edited
Loading

Workspace service termination is switched off in the spi branch, workspaces are not stopped properly when master servers stops. The goal of the issue is to adapt existing workspace service termination to the new Workspace SPI, so all the running workspaces are gracefully terminated before master server is stopped.

In master branch workspace service termination is implemented in core-system module, while it's better to implement terminations independently, directly in components, so the components don't required to expose their internals needed for termination. Consider making ServiceTermination interface public and implement it directly in core-workspace module.

depends on #5644
@akorneta akorneta added the target/branch Indicates that a PR will be merged into a branch other than master. label Jul 10, 2017
@akorneta akorneta changed the title Termination of workspace API Termination of workspace infrastructure Jul 10, 2017
@akorneta akorneta mentioned this issue Jul 10, 2017
Closed
@gazarenkov gazarenkov mentioned this issue Jul 10, 2017
Closed
15 tasks
@akorneta akorneta added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Jul 11, 2017
@akorneta akorneta added the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 27, 2017
@akorneta akorneta mentioned this issue Jul 31, 2017
Merged
@garagatyi garagatyi mentioned this issue Aug 3, 2017
Closed
@akorneta akorneta removed the status/in-progress This issue has been taken by an engineer and is under active development. label Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voievodin voievodin

@akorneta akorneta

Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@voievodin @akorneta