Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to match machine configuration to OpenShift container by annotations #7308

Closed
sleshchenko opened this issue Nov 10, 2017 · 2 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Nov 10, 2017

Description

Now machine configuration is matched to OpenShift container by pod and container names. It means that machine name should be specified in the following format web/main where web is pod name and main is the name of a container in the specified pod.
It works fine for openshift recipes but it doesn't work while converting dockerimage recipes to openshift recipes. To solve this problem it is needed to add an ability to match machine from configuration to OpenShift container without the composite machine name.
It's proposed to rework OpenShift container to machine configuration in the following way:

  1. Get the name of the container.
  2. Check if Pod annotations contains annotation org.eclipse.che.{containerName}.machine_name
  • if yes - use the value of this annotations as machine name for this container
  • if not - use the following value {POD_NAME}/{CONTAINER_NAME} as machine name for this container.

P.S. Name of org.eclipse.che.{containerName}.machine_name annotation can be discussed and changed.

@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. target/che6 labels Nov 10, 2017
@sleshchenko
Copy link
Member Author

this issue is needed for #5904

@akorneta akorneta self-assigned this Nov 13, 2017
@akorneta akorneta added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. labels Nov 13, 2017
@akorneta akorneta removed the status/in-progress This issue has been taken by an engineer and is under active development. label Nov 16, 2017
@sleshchenko
Copy link
Member Author

Note that org.eclipse.che.container.{containerName}.machine_name is used for matching of a machine to OpenShift container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

2 participants