Add an ability to match machine configuration to OpenShift container by annotations #7391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akorneta
added
kind/task
akorneta
requested review from
skabashnyuk,
riuvshin,
garagatyi and
sleshchenko
riuvshin
approved these changes
Nov 15, 2017
mshaposhnik
reviewed
Nov 15, 2017
| */ | ||
| public static String podName(String machineName) { | ||
| return machineName.split("/")[0]; | ||
| public static String machineName(Pod pod, Container container) { |
There was a problem hiding this comment.
You dont use anything from container except the name. Maybe leave param containerName?
There was a problem hiding this comment.
I'd leave Container as it gives us an opportunity to use something else from container later.
sleshchenko
reviewed
Nov 15, 2017
|
|
||
| @BeforeMethod | ||
| public void setup() throws Exception { | ||
| MockitoAnnotations.initMocks(this); | ||
| internalRuntime = | ||
| new OpenShiftInternalRuntime( | ||
| internalRuntimeSpy = |
There was a problem hiding this comment.
Are you sure that you need spy here?
sleshchenko
reviewed
Nov 15, 2017
| * Returns pod name that is extracted from machine name. | ||
| * | ||
| * @see #machineName(String, String) | ||
| * Returns machine name that has the following format `{POD_NAME}/{CONTAINER_NAME}` or machine |
There was a problem hiding this comment.
Please rewrite java doc here to make clear that there are three possible ways in which machine name can be constructed.
I mean
- MACHINE_NAME_ANNOTATION_FMT
- CHE_ORIGINAL_NAME_LABEL
- Names of objects
sleshchenko
approved these changes
Nov 16, 2017
garagatyi
approved these changes
Nov 16, 2017
akorneta
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides a way to implement converter from docker image recipes into OpenShift recipes.
Provides an ability to use simple (not composite) machine names in OpenShift recipes.
Fix provisioning of Che debug property in deploy_che.sh.
Adds logs filtering for foreign containers while workspace start.
What issues does this PR fix or reference?
#7308
#7367
Release Notes
n/a