Apache Camel Language LSP client compatible with Java files #10264

apupier · 2018-07-04T12:39:45Z

Signed-off-by: Aurélien Pupier apupier@redhat.com

What does this PR do?

Triggering the Apache Camel Language Server on Java files

What issues does this PR fix or reference?

#10262

Release Notes

Docs PR

codenvy-ci · 2018-07-04T12:41:02Z

Can one of the admins verify this patch?

apupier · 2018-07-04T12:42:35Z

to test it, Apache Camel Language Server "Installer"needs to be activated:

and this file with a .java extension can be used :

import org.apache.camel.builder.RouteBuilder;

/**
 * A Camel Java DSL Router
 */
public class MyRouteBuilder extends RouteBuilder {

    /**
     * Let's configure the Camel routing rules using Java code...
     */
    public void configure() {

        // here is a sample which processes the input files
        // (leaving them in place - see the 'noop' flag)
        // then performs content based routing on the message using XPath
        from("file:src/data?noop=true&antExclude=aa&antFilterCaseSensitive=true&runLoggingLevel=OFF")
            .choice()
                .when(xpath("/person/city = 'London'"))
                    .to("file:target/messages/uk")
                .otherwise()
                    .to("file:target/messages/others");
    }
}

if you call the completion just after the quote from(" L.16 you should have several results including ahc-httpUri

codenvy-ci · 2018-07-04T12:44:02Z

Can one of the admins verify this patch?

codenvy-ci · 2018-07-04T12:44:06Z

Can one of the admins verify this patch?

benoitf · 2018-07-04T12:50:10Z

ci-test

codenvy-ci · 2018-07-04T17:52:43Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

apupier · 2018-07-04T18:41:39Z

there are some test failures but they seem not related to my PR (as far I understand them)
They have always a success rate which is not 100%, does it mean that they are all flaky tests?

tolusha · 2018-07-05T08:34:09Z

@musienko-maxim
Could you have a look at tests result?

dkulieshov · 2018-07-05T09:39:43Z

@apupier

Hi, recently there were introduced several changes to regular expressions for language servers, they were called upon to give regexes more flexibility, and as of what I see probably by a mistake those changes were not applied to Camel language regexes, so I would recommend to replace

private static final String REGEX = ".*\\.(xml|java)";

with

private static final String REGEX = ".*\\.(xml|java)$";

apupier · 2018-07-05T09:52:37Z

@dkuleshov updated PR with your advice

skabashnyuk · 2018-07-05T11:41:02Z

ci-test

apupier · 2018-07-05T14:18:25Z

with my PR it seems that the Java Language Server is not started at all:

i have no Java completion, neither Java Syntax coloring. Does it mean that 2 Language Server on the same file is not supported? Or that I misconfigured something?

codenvy-ci · 2018-07-05T19:09:19Z

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

apupier · 2018-07-06T06:59:42Z

I tend to say that several LSP on same file should work given this code:
https://github.com/eclipse/che/blob/89d6c1664aee6a25b117b2a63216e1804742d0da/wsagent/che-core-api-languageserver/src/main/java/org/eclipse/che/api/languageserver/TextDocumentService.java#L246-L247

I'm not able to have a working development environment so can't really investigate more unfortunately

apupier · 2018-07-06T07:24:37Z

@tsmaeder explained me that this approach won't work until jdt.ls is used in Che #6157 .

musienko-maxim · 2018-07-06T10:13:08Z

After last selenium launching, was found that java files from a maven project have wrong syntax highlighting. It may be depend on incorrect detecting of editor type.
Steps to reproduce:

Create a workspace based on javastack.
Create for instance the spring project from wizard and open the GreetingController file
More details on the screenshot:

vparfonov · 2018-07-06T13:53:35Z

do not merge before @musienko-maxim approve it

apupier · 2018-07-06T14:01:44Z

this PR cannot be merged until jdt.ls has been integrated

apupier · 2018-10-25T09:51:55Z

ci-test

riuvshin · 2018-10-25T10:50:43Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:10264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

apupier · 2018-10-25T11:12:48Z

the ci build error i smentioning missing theia stuff but this PR is not touching it.

apupier · 2018-10-25T11:12:59Z

ci-test

riuvshin · 2018-10-25T11:52:36Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:10264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

dkulieshov · 2018-10-25T14:11:55Z

@apupier Seems like at the moment for some reason CI tests fail during build, so not to waste your time I would recommend you to wait until the issue is resolved and then relaunch the tests. @musienko-maxim probably will tell you more.

apupier · 2018-10-25T16:31:35Z

ok, thanks for letting me know. Please ping me when it is fixed and if I need to rebase on master to get the fix too.

…che#10262) - remove language declaration for Camel, Camel is not a language type but just a provider on top of other languages Signed-off-by: Aurélien Pupier <apupier@redhat.com>

apupier · 2018-10-26T14:40:43Z

ci-test

apupier · 2018-10-29T10:42:03Z

ci-test

riuvshin · 2018-10-29T14:35:37Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:10264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

apupier · 2018-10-29T15:37:00Z

some tests failures seems due to this regression: #11760

for instance here is the screenshot of one failing test:

apupier · 2018-10-30T07:35:36Z

relaunching because it is working manually and the modifications should not have an impact to these failed tests

apupier · 2018-10-30T07:35:41Z

ci-test

riuvshin · 2018-10-30T10:53:05Z

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:10264
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

apupier · 2018-10-31T07:38:34Z

without any changes, another set of tests has failed.
i'm not able to launch tests locally.
Testing the feature manually works well.

Can someone review this PR?

dkulieshov · 2018-10-31T10:05:59Z

@musienko-maxim can you please check test results?

musienko-maxim · 2018-11-05T13:59:30Z

So we had many failed tests - main reason problems on test-infrastructure. After rerunning all problem tests passed properly. But we have just unexpected regression with ApacheCamelFileEditingTest. The logic of tests works as well. But we need some clarification. @SkorikSergey is going to ask you about that

SkorikSergey · 2018-11-05T14:03:55Z

@apupier ApacheCamelFileEditingTest selenium test failed due to missing expected "Initialized language server 'org.eclipse.che.plugin.camel.server.languageserver'' message in "dev-machine" console after opening "camel.xml" file. And there is an exception in "dev-machine" console.

apupier · 2018-11-05T14:10:21Z

stacktrace is similar to the one in #11760
looks alike the JavaLanguageServerExtensionService is not robust enough when there are projects containing a single file

SkorikSergey · 2018-11-05T15:03:37Z

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1111//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

apupier · 2018-11-07T16:44:45Z

Do I need to change something or to provide more information to have this PR merged?

dmytro-ndp · 2018-11-07T17:08:55Z

Looks like you have enough approvals to merge the PR into the master.

apupier · 2018-11-07T17:33:05Z

Just to be sure that it is clear, I don't have rights to merge myself.

apupier requested a review from vparfonov as a code owner July 4, 2018 12:39

benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 4, 2018

benoitf requested a review from tsmaeder July 4, 2018 13:10

benoitf assigned apupier Jul 4, 2018

tolusha requested a review from dkulieshov July 5, 2018 07:22

dkulieshov requested a review from musienko-maxim July 5, 2018 09:40

apupier force-pushed the 10262-HaveCamelLSPWorkingWithJava branch from b39ba79 to 4d491c0 Compare July 5, 2018 09:51

dkulieshov approved these changes Jul 5, 2018

View reviewed changes

apupier force-pushed the 10262-HaveCamelLSPWorkingWithJava branch from 4d491c0 to 745746b Compare September 21, 2018 13:26

apupier mentioned this pull request Sep 21, 2018

[DRAFT]Apache Camel Language LSP client compatible with Java files (#10262) #11311

Closed

apupier force-pushed the 10262-HaveCamelLSPWorkingWithJava branch from 745746b to d512e26 Compare October 18, 2018 06:47

apupier requested a review from ashumilova as a code owner October 18, 2018 06:47

apupier force-pushed the 10262-HaveCamelLSPWorkingWithJava branch from 20694ff to 790270a Compare October 25, 2018 09:50

Apache Camel Language LSP client compatible with Java files (eclipse-…

ebba742

…che#10262) - remove language declaration for Camel, Camel is not a language type but just a provider on top of other languages Signed-off-by: Aurélien Pupier <apupier@redhat.com>

apupier force-pushed the 10262-HaveCamelLSPWorkingWithJava branch from 790270a to ebba742 Compare October 26, 2018 14:39

SkorikSergey approved these changes Nov 5, 2018

View reviewed changes

dmytro-ndp merged commit 8089d3d into eclipse-che:master Nov 7, 2018

benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 7, 2018

benoitf added this to the 6.14.0 milestone Nov 7, 2018

Apache Camel Language LSP client compatible with Java files #10264

Apache Camel Language LSP client compatible with Java files #10264

Conversation

apupier commented Jul 4, 2018

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

codenvy-ci commented Jul 4, 2018

apupier commented Jul 4, 2018 • edited Loading

codenvy-ci commented Jul 4, 2018

codenvy-ci commented Jul 4, 2018

benoitf commented Jul 4, 2018

codenvy-ci commented Jul 4, 2018

apupier commented Jul 4, 2018 • edited Loading

tolusha commented Jul 5, 2018

dkulieshov commented Jul 5, 2018

apupier commented Jul 5, 2018

skabashnyuk commented Jul 5, 2018

apupier commented Jul 5, 2018

codenvy-ci commented Jul 5, 2018

apupier commented Jul 6, 2018

apupier commented Jul 6, 2018

musienko-maxim commented Jul 6, 2018 • edited Loading

vparfonov commented Jul 6, 2018

apupier commented Jul 6, 2018

apupier commented Oct 25, 2018

riuvshin commented Oct 25, 2018

apupier commented Oct 25, 2018

apupier commented Oct 25, 2018

riuvshin commented Oct 25, 2018

dkulieshov commented Oct 25, 2018

apupier commented Oct 25, 2018

apupier commented Oct 26, 2018

apupier commented Oct 29, 2018

riuvshin commented Oct 29, 2018

apupier commented Oct 29, 2018 • edited Loading

apupier commented Oct 30, 2018

apupier commented Oct 30, 2018

riuvshin commented Oct 30, 2018

apupier commented Oct 31, 2018

dkulieshov commented Oct 31, 2018

musienko-maxim commented Nov 5, 2018 • edited Loading

SkorikSergey commented Nov 5, 2018

apupier commented Nov 5, 2018

SkorikSergey commented Nov 5, 2018

apupier commented Nov 7, 2018

dmytro-ndp commented Nov 7, 2018

apupier commented Nov 7, 2018

apupier commented Jul 4, 2018 •

edited

Loading

apupier commented Jul 4, 2018 •

edited

Loading

musienko-maxim commented Jul 6, 2018 •

edited

Loading

apupier commented Oct 29, 2018 •

edited

Loading

musienko-maxim commented Nov 5, 2018 •

edited

Loading