Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make documentation links configurable #12294

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Make documentation links configurable #12294

merged 1 commit into from
Dec 28, 2018

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Anna Shumilova ashumilo@redhat.com

What does this PR do?

Makes links to documentation - factories, organizations, stacks, general docs - configurable by product.json.

What issues does this PR fix or reference?

#12052

@ashumilova ashumilova added kind/enhancement A feature request - must adhere to the feature request template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Dec 27, 2018
@ashumilova ashumilova self-assigned this Dec 27, 2018
@ashumilova ashumilova requested a review from benoitf as a code owner December 27, 2018 14:22
@ashumilova
Copy link
Contributor Author

ci-test

@ashumilova
Copy link
Contributor Author

ci-build

@che-bot
Copy link
Contributor

che-bot commented Dec 27, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12294
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova
Make documentation links configurable
c0ef928 
Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
@ashumilova
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Dec 28, 2018

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12294
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova
Copy link
Contributor Author

screenshot from 2018-12-28 14-52-22

@ashumilova ashumilova merged commit a082fbe into master Dec 28, 2018
@ashumilova ashumilova deleted the fix_doc_links branch December 28, 2018 13:39
@garagatyi garagatyi mentioned this pull request Jan 2, 2019
Merged
@benoitf benoitf added this to the 6.17.0 milestone Jan 14, 2019
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@akurinnoy akurinnoy akurinnoy approved these changes

@benoitf benoitf Awaiting requested review from benoitf

Assignees

@ashumilova ashumilova

Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
6.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ashumilova @che-bot @olexii4 @akurinnoy @benoitf