Add plugin generator to the theia-dev image. #12478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
benoitf,
evidolob,
mmorhun and
akurinnoy
che-bot
added
status/code-review
evidolob
approved these changes
Jan 21, 2019
benoitf
approved these changes
Jan 21, 2019
dockerfiles/theia-dev/Dockerfile
Outdated
| @@ -45,6 +45,7 @@ RUN npm config set prefix "${HOME}/.npm-global" && \ | |||
| echo "--global-folder \"${HOME}/.yarn-global\"" > ${HOME}/.yarnrc && \ | |||
| # add eclipse che theia generator | |||
| yarn global add @eclipse-che/theia-generator@0.0.1-1547456396 && \ | |||
| yarn global add yo @theia/generator-plugin@0.0.1-1540209403 && \ | |||
There was a problem hiding this comment.
should we add it to the previous line instead of running again yarn tool ?
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
…atorToTheiaDevImage
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add plugin generator to the theia-dev image.
What issues does this PR fix or reference?
#12425
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com