Add docker & native build of devfile docs #12602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
che-bot
added
status/code-review
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
sleshchenko
reviewed
Feb 6, 2019
| @@ -191,4 +191,133 @@ | |||
| </plugin> | |||
| </plugins> | |||
| </build> | |||
| <profiles> | |||
| <profile> | |||
| <id>devfile-docs-docker</id> | |||
There was a problem hiding this comment.
Maybe it would be better to move Devfile docs generation to a separate maven module. WDYT?
There was a problem hiding this comment.
It anyway will have to contain that profiles (to allow different build types). And they are incactive by default. So we will have module which will do nothing 99% of time.
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
Signed-off-by: Max Shaposhnik <mshaposh@redhat.com>
|
@mshaposhnik please discuss with @riuvshin do we need maven profilers or not. Maybe the dedicated script is enough. And let us know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds possibility to build devfile docs from json schema using docker or native using special build profiles.
What issues does this PR fix or reference?
#12524
Release Notes
N/A
Docs PR
N/A