Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devfile for dashboard #12757

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Add devfile for dashboard #12757

merged 2 commits into from
Mar 1, 2019

Conversation

evidolob
Copy link
Contributor

What does this PR do?

Provide devfile for dashboard development, and new docker image for dashboard development

What issues does this PR fix or reference?

#12228

Release Notes

Docs PR

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 25, 2019
actions:
- type: exec
tool: dash-dev
command: cd /projects/che/dashboard && node_modules/.bin/gulp serve --server=${CHE_API_EXTERNAL%????}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%???? is the correct syntax ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, its in POSIX spec, see https://unix.stackexchange.com/a/259042

dockerfiles/dashboard-dev/src/entrypoint.sh Outdated Show resolved Hide resolved
dockerfiles/dashboard-dev/Dockerfile Outdated Show resolved Hide resolved
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob mentioned this pull request Feb 27, 2019
40 tasks
@evidolob evidolob merged commit e185665 into master Mar 1, 2019
@evidolob evidolob deleted the dashboard-devfile branch March 1, 2019 08:23
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* #12228 add devfile for dashboard

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants