Add option to Che deployment.yaml to allow self-signed certificates for OIDC #12874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Collier <John.J.Collier@ibm.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
johnmcollier
requested review from
l0rd,
riuvshin and
sleshchenko
as code owners
|
Can one of the admins verify this patch? |
ghost
approved these changes
Mar 12, 2019
|
ci-build |
sleshchenko
approved these changes
Mar 13, 2019
l0rd
approved these changes
Mar 13, 2019
|
Hey, just wondering - Is there anything else I need to do for this PR before it's merged? Thanks! |
|
Thank you @johnmcollier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Collier John.J.Collier@ibm.com
What does this PR do?
If Che is installed via Helm on to a Kubernetes cluster with self-signed certificates and multiuser is enabled, Eclipse Che will fail to start with the following error:
This PR adds a
global.tls.useSelfSignedCertsvalue to values.yaml. When enabled, it has theCHE_SELF__SIGNED__CERTenvironment variable added to Che's deployment.yaml, allowing the user to pass in the cluster's ca.crt into theself-signed-certificatesecret.What issues does this PR fix or reference?
#12863
Release Notes
N/A
Docs PR
N/A