Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard: fail build when webpack has errors #12911

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Dashboard: fail build when webpack has errors #12911

merged 1 commit into from
Nov 26, 2019

Conversation

ljelinkova
Copy link
Contributor

What does this PR do?

Changes the dashboard build so that when typescript compilation fails (or anything processed by webpack), the whole build fails too. The watch mode should not fail in case of webpack error.

Note that this PR depends on resolving all current compilation problems (e.g #12826)

What issues does this PR fix or reference?

#12902

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2019

Can one of the admins verify this patch?

ashumilova
ashumilova suggested changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@ashumilova ashumilova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The introduced changes make sense, but IDE2 teams needs to fix compilation errors before merging this PR.

@ashumilova ashumilova mentioned this pull request Mar 20, 2019
Closed
36 tasks
@ashumilova
Copy link
Contributor

PR from IDE2 team #12955

@evidolob evidolob mentioned this pull request Apr 3, 2019
Closed
50 tasks
@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@ashumilova ashumilova mentioned this pull request Apr 23, 2019
Closed
25 tasks
@ashumilova
Copy link
Contributor

@ljelinkova checked on my side - it works. But need to update the branch with master to pass checks on this PR.

@ljelinkova
Copy link
Contributor Author

I've rebased to master.

@ashumilova
Copy link
Contributor

ci-build

@monaka monaka requested a review from ashumilova May 4, 2019 02:56
@benoitf
Copy link
Contributor

benoitf commented May 6, 2019

ci-build

olexii4
olexii4 reviewed May 6, 2019
View reviewed changes
dashboard/gulp/scripts.js Outdated Show resolved Hide resolved
dashboard/gulp/scripts.js Outdated Show resolved Hide resolved
@evidolob evidolob mentioned this pull request May 15, 2019
Closed
30 tasks
@ljelinkova
Dashboard: fail build when webpack has errors
fcb7b05 
Signed-off-by: Lucia Jelinkova <ljelinko@redhat.com>
@evidolob evidolob mentioned this pull request Jun 5, 2019
Closed
29 tasks
@ljelinkova
Copy link
Contributor Author

@ashumilova @olexii4 What blocks this PR from merging?

@benoitf
Copy link
Contributor

benoitf commented Jun 11, 2019

ci-build

@benoitf
Copy link
Contributor

benoitf commented Jun 11, 2019

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jun 11, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12911
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@benoitf
Copy link
Contributor

benoitf commented Jun 11, 2019

@ljelinkova there are webpack errors thus the build is failing

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 27, 2019
@ashumilova ashumilova mentioned this pull request Jul 2, 2019
Closed
16 tasks
@evidolob evidolob mentioned this pull request Jul 18, 2019
Closed
18 tasks
@evidolob evidolob mentioned this pull request Aug 7, 2019
Closed
26 tasks
@evidolob evidolob mentioned this pull request Aug 28, 2019
Closed
20 tasks
@sunix sunix mentioned this pull request Sep 18, 2019
Closed
21 tasks
@evidolob evidolob mentioned this pull request Oct 9, 2019
Closed
13 tasks
@evidolob evidolob mentioned this pull request Oct 31, 2019
Closed
22 tasks
@olexii4
Copy link
Contributor

olexii4 commented Nov 19, 2019

ci-test

@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Nov 19, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 19, 2019

E2E tests of Eclipse Che Multiuser on OCP has been successful:

@olexii4
Copy link
Contributor

olexii4 commented Nov 20, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 20, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@olexii4
Copy link
Contributor

olexii4 commented Nov 21, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 21, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@olexii4
Copy link
Contributor

olexii4 commented Nov 21, 2019

ci-test

@olexii4
Copy link
Contributor

olexii4 commented Nov 21, 2019

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Nov 21, 2019

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@olexii4
Copy link
Contributor

olexii4 commented Nov 21, 2019

@ljelinkova It works. But need to update the branch with master to pass checks on this PR.

@che-bot
Copy link
Contributor

che-bot commented Nov 21, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

@olexii4
Copy link
Contributor

olexii4 commented Nov 26, 2019

ci-test

@olexii4
Copy link
Contributor

olexii4 commented Nov 26, 2019

ci-build

@olexii4 olexii4 merged commit 51bb0bb into eclipse-che:master Nov 26, 2019
@che-bot che-bot added this to the 7.5.0 milestone Nov 26, 2019
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 26, 2019
@che-bot
Copy link
Contributor

che-bot commented Nov 26, 2019

E2E tests of Eclipse Che Multiuser on OCP has failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akurinnoy akurinnoy akurinnoy approved these changes

@olexii4 olexii4 olexii4 approved these changes

@ashumilova ashumilova ashumilova approved these changes

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ljelinkova @che-bot @ashumilova @musienko-maxim @benoitf @olexii4 @akurinnoy