Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable to load GWT-IDE app on Multi-user with Multi-host env. #13142

Closed
wants to merge 1 commit into from
Closed

Enable to load GWT-IDE app on Multi-user with Multi-host env. #13142

wants to merge 1 commit into from

Conversation

monaka
Copy link
Member

@monaka monaka commented Apr 14, 2019 •
edited
Loading

Alternative of #13026.

What does this PR do?

In "Multi-user with Multi-host" environment,

Some code in IDE.html must be skipped because they are done in loader.html.

IDE and dashboard cannot share (copy) Kyecloak settings because of the cross domain scripting.
So IDEs must check whether itself runs in cross domain and choose their machine-token or another way for calling /api endpoints in case it was required.
(This patch does not contain patches how to call /api. This is just for checking cross-domain and setting Keycloak off. )

What issues does this PR fix or reference?

Will fixes #13026 #12585
This may resolve some part of #12243.
After fixes by this PR, GWT-IDE will crashed by #12273.
#13137 is a part of the answer how to call /api from GWT-IDE.

@monaka monaka added the kind/bug Outline of a bug - must adhere to the bug report template. label Apr 14, 2019
@che-bot
Copy link
Contributor

che-bot commented Apr 14, 2019

Can one of the admins verify this patch?

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Apr 14, 2019

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Apr 14, 2019

Can one of the admins verify this patch?

@monaka monaka mentioned this pull request Apr 14, 2019
Closed
vparfonov
vparfonov reviewed Apr 17, 2019
View reviewed changes
...he-multiuser-keycloak-ide/src/main/java/org/eclipse/che/multiuser/keycloak/ide/Keycloak.java
@@ -21,6 +21,16 @@ protected Keycloak() {
super();
}

public static native boolean isMultihostEnvironment() /*-{
try {
var dummy = $wnd.parent['_keycloak'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dummy var unused here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vparfonov Just for checking here if $wnd.parent['_keycloak'] is readable.
What is the best way to check it?

@skabashnyuk
Copy link
Contributor

ci-test

@che-bot
Copy link
Contributor

che-bot commented Apr 17, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13142
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@monaka
Copy link
Member Author

monaka commented Apr 21, 2019

I reviewed the result of ci-integrationt-test https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1717/.
All builds and tests task looks passed. The cause of failed will be tests with selenium. And no test result available (Jenkins returns 404 error).
I guess these test failures might be caused by the build server...

@skabashnyuk
Copy link
Contributor

@eclipse/eclipse-che-qa can you take a look on test too?

@musienko-maxim
Copy link
Contributor

Can one of the admins verify this PR?

@SkorikSergey
Copy link
Contributor

ci-build

@monaka monaka mentioned this pull request Apr 23, 2019
Merged
@monaka
Copy link
Member Author

monaka commented May 1, 2019 •
edited
Loading

@SkorikSergey Hmm... It is also built on my CI server (without any caches)... https://dev.azure.com/pizzafactory/camino/_build/results?buildId=575

@SkorikSergey
Copy link
Contributor

ci-build

@monaka monaka mentioned this pull request May 9, 2019
Closed
@benoitf
Copy link
Contributor

benoitf commented Jun 26, 2019

ci-build

@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 27, 2019
@monaka
Enable to load GWT-IDE app on Multi-user with Multi-host env.
64f321c 
Some code in IDE.html must be skipped because they are done in loader.html.
IDE and dashboard cannot share Kyecloak settings because of the closs domain scripting.
IDEs must use their machine-token or another way for calling `/api` endpoints.
(This patch does not contain patches how to call `/api`. This is just for setting Keycloak off. )

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
@monaka
Copy link
Member Author

monaka commented Jul 25, 2019

I close this as it was deprecated by #13788. The part of this PR may be required if GWT-IDE was back.

@monaka monaka closed this Jul 25, 2019
@monaka monaka deleted the pr-skip-initializing-keycloak-on-multi-host-env branch July 25, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov left review comments

@ashumilova ashumilova Awaiting requested review from ashumilova

@benoitf benoitf Awaiting requested review from benoitf

@mshaposhnik mshaposhnik Awaiting requested review from mshaposhnik

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@monaka @che-bot @skabashnyuk @musienko-maxim @SkorikSergey @benoitf @vparfonov